Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retry admin request limit exceeded error #669

Merged
merged 3 commits into from Nov 30, 2020

Conversation

olavloite
Copy link
Collaborator

Automatically retry requests that fail because the admin requests per seconds limit has been exceeded using an exponential backoff.

Fixes #655 and others

Automatically retry requests that fail because the admin requests per seconds
limit has been exceeded using an exponential backoff.

Fixes #655 and others
@olavloite olavloite requested a review from a team as a code owner November 24, 2020 14:17
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Nov 24, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 24, 2020
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 24, 2020
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #669 (441dcf2) into master (77ed87c) will increase coverage by 0.05%.
The diff coverage is 86.74%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #669      +/-   ##
============================================
+ Coverage     84.06%   84.11%   +0.05%     
- Complexity     2497     2506       +9     
============================================
  Files           141      142       +1     
  Lines         13812    13902      +90     
  Branches       1317     1321       +4     
============================================
+ Hits          11611    11694      +83     
- Misses         1655     1662       +7     
  Partials        546      546              
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/spanner/spi/v1/GapicSpannerRpc.java 83.22% <86.58%> (+0.59%) 81.00 <1.00> (+1.00)
.../google/cloud/spanner/SpannerExceptionFactory.java 82.47% <86.66%> (+1.98%) 46.00 <3.00> (+7.00)
...anner/AdminRequestsPerMinuteExceededException.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
.../com/google/cloud/spanner/AbstractReadContext.java 86.76% <0.00%> (+0.61%) 47.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ed87c...441dcf2. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 3f9f74a into master Nov 30, 2020
@thiagotnunes thiagotnunes deleted the retry-admin-request-exceeded branch November 30, 2020 23:04
@thiagotnunes thiagotnunes mentioned this pull request Dec 1, 2020
thiagotnunes pushed a commit that referenced this pull request May 6, 2021
* feat: retry admin request limit exceeded error

Automatically retry requests that fail because the admin requests per seconds
limit has been exceeded using an exponential backoff.

Fixes #655 and others

* fix: remove unused variable

* fix: extract strings to constants
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#4712

Changes:

chore: regenerate API index

  Source-Link: googleapis/googleapis@ee78ed7

feat(aiplatform): add Vizier service to aiplatform v1
  Committer: @dizcology
  PiperOrigin-RevId: 394116440
  Source-Link: googleapis/googleapis@67c780b

docs(dialogflow/cx): clarified some LRO types docs: fixed some wrong update mask descriptions
  PiperOrigin-RevId: 394033461
  Source-Link: googleapis/googleapis@aa15f32

chore: regenerate API index

  Source-Link: googleapis/googleapis@2127126

feat: add prediction service RPC RawPredict to aiplatform_v1beta1 feat: add tensorboard service RPCs to aiplatform_v1beta1: BatchCreateTensorboardRuns, BatchCreateTensorboardTimeSeries, WriteTensorboardExperimentData feat: add model_deployment_monitoring_job to Endpoint in aiplatform_v1beta1 feat: add deployment_group to DeployedIndex in aiplatform_v1beta1 feat: add ModelEvaluationExplanationSpec in aiplatform_v1beta1
  Committer: @dizcology
  PiperOrigin-RevId: 393890669
  Source-Link: googleapis/googleapis@321abab
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\*
---
### [2.5.3](https://www.github.com/googleapis/java-spanner-jdbc/compare/v2.5.2...v2.5.3) (2021-11-15)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.5.0 ([googleapis#668](https://www.github.com/googleapis/java-spanner-jdbc/issues/668)) ([d453234](https://www.github.com/googleapis/java-spanner-jdbc/commit/d45323445d3e4a0753bed6cfe858fa891bca468e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner.it.ITDatabaseAdminTest: listPagination failed
3 participants