Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize and handle 'Instance not found' #60

Closed
olavloite opened this issue Feb 5, 2020 · 0 comments · Fixed by #61
Closed

Recognize and handle 'Instance not found' #60

olavloite opened this issue Feb 5, 2020 · 0 comments · Fixed by #61
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@olavloite
Copy link
Collaborator

The client library recognizes DatabaseNotFound errors and handles these by halting any further RPCs for the database, as the RPCs would fail. This should also be done for InstanceNotFound.
@olavloite olavloite added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 5, 2020
@olavloite olavloite self-assigned this Feb 5, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Feb 5, 2020
olavloite added a commit that referenced this issue Feb 5, 2020
@olavloite
fix: stop sending RPCs on InstanceNotFound
996f2ac 
The session pool should handle InstanceNotFound in the same way
as DatabaseNotFound errors, i.e. stop sending RPCs and also
consider an instance that has been re-created with the same name
as a different instance, and hence require the user to re-create
any database client before it can be used again.

Fixes #60
@olavloite olavloite mentioned this issue Feb 5, 2020
Merged
skuruppu pushed a commit that referenced this issue Feb 6, 2020
@olavloite
fix: stop sending RPCs on InstanceNotFound (#61)
7618ac8 
The session pool should handle InstanceNotFound in the same way
as DatabaseNotFound errors, i.e. stop sending RPCs and also
consider an instance that has been re-created with the same name
as a different instance, and hence require the user to re-create
any database client before it can be used again.

Fixes #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: stop sending RPCs on InstanceNotFound googleapis/java-spanner
1 participant
@olavloite