Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use streaming retry settings for ResumableStreamIterator #49

Merged
merged 2 commits into from Jan 30, 2020

Conversation

olavloite
Copy link
Collaborator

This PR moves the custom Backoff functionality and settings from the SpannerImpl class to AbstractResultSet, as that is the only place where it is still in use.

The Backoff configuration was previously a hard coded value. It now uses the gapic configuration for streaming RPCs as the backoff is only used for the ResumableStreamIterator which is used by the executeStreamingSql and streamingRead RPCs.

Updates #20

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants