Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Async API integration tests might be flaky #327

Closed
skuruppu opened this issue Jul 9, 2020 · 1 comment · Fixed by #337
Closed

Some Async API integration tests might be flaky #327

skuruppu opened this issue Jul 9, 2020 · 1 comment · Fixed by #337
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@skuruppu
Copy link
Contributor

skuruppu commented Jul 9, 2020 •
edited

I just saw this failure for AsyncRunnerTest.asyncRunnerWithBatchUpdateCommitAborted in one of the presubmit runs. I haven't seen it before so I assume it's a flaky test.
@skuruppu skuruppu added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jul 9, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jul 9, 2020
@skuruppu
Copy link
Contributor Author

skuruppu commented Jul 9, 2020 •
edited

Here's another one, but this time it's AsyncResultSetImplStressTest(sponge_log).cancel[rows = 5].

@skuruppu skuruppu changed the title AsyncRunnerTest.asyncRunnerWithBatchUpdateCommitAborted might be flaky Some Async API integration tests might be flaky Jul 9, 2020
olavloite added a commit that referenced this issue Jul 9, 2020
@olavloite
test: fix potential race condition in Async ResultSet
161db8e 
If an AsyncResultSet was paused directly after receiving its last row and
then cancelled while in paused mode, there was a small chance that the
callback would not be called a last time to indicate to the user that the
result set had been cancelled.

Updates #327
@olavloite olavloite mentioned this issue Jul 9, 2020
Merged
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 9, 2020
@skuruppu skuruppu mentioned this issue Jul 10, 2020
Merged
1 task
skuruppu pushed a commit that referenced this issue Jul 10, 2020
@olavloite
test: fix potential race condition in Async ResultSet (#333)
fb26abe 
If an AsyncResultSet was paused directly after receiving its last row and
then cancelled while in paused mode, there was a small chance that the
callback would not be called a last time to indicate to the user that the
result set had been cancelled.

Updates #327
@skuruppu skuruppu added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. labels Jul 10, 2020
olavloite added a commit that referenced this issue Jul 10, 2020
@olavloite
fix: fix potential unnecessary transaction retry
12c2110 
A transaction could in some circumstances be retried after an abort using the previous
transaction id. This would cause the retry to abort directly as well, and then start a
new transaction. This extra loop has now been removed.

Fixes #327
@olavloite olavloite mentioned this issue Jul 10, 2020
Merged
skuruppu pushed a commit that referenced this issue Jul 14, 2020
@olavloite
fix: fix potential unnecessary transaction retry (#337)
1a4f4fd 
A transaction could in some circumstances be retried after an abort using the previous
transaction id. This would cause the retry to abort directly as well, and then start a
new transaction. This extra loop has now been removed.

Fixes #327
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 16, 2020
@release-please
chore: release 1.59.0 (#352)
0f99196 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.59.0](https://www.github.com/googleapis/java-spanner/compare/v1.58.0...v1.59.0) (2020-07-16)


### Features

* add support for NUMERIC data type ([#193](https://www.github.com/googleapis/java-spanner/issues/193)) ([b38a91d](https://www.github.com/googleapis/java-spanner/commit/b38a91d8daac264b9dea327d6b31430d9599bd78))
* spanner NUMERIC type ([#349](https://www.github.com/googleapis/java-spanner/issues/349)) ([78c3192](https://www.github.com/googleapis/java-spanner/commit/78c3192266c474fc43277a8bf3f15caa968a0100))


### Bug Fixes

* check if emulator is running if env var is set ([#340](https://www.github.com/googleapis/java-spanner/issues/340)) ([597f501](https://www.github.com/googleapis/java-spanner/commit/597f501803e6d58717a6e3770e6fd3f34454e9a5))
* fix potential unnecessary transaction retry ([#337](https://www.github.com/googleapis/java-spanner/issues/337)) ([1a4f4fd](https://www.github.com/googleapis/java-spanner/commit/1a4f4fd675a1580c87ad1d53c650a20bd2ff4811)), closes [#327](https://www.github.com/googleapis/java-spanner/issues/327)
* respect PDML timeout when using streaming RPC ([#338](https://www.github.com/googleapis/java-spanner/issues/338)) ([d67f108](https://www.github.com/googleapis/java-spanner/commit/d67f108e86925c1296e695db8e78fa82e11fa4fa))
* runs sample tests in java 8 and java 11 ([#345](https://www.github.com/googleapis/java-spanner/issues/345)) ([b547e31](https://www.github.com/googleapis/java-spanner/commit/b547e31d095be3cf1646e0e9c07bfc467ecc3c22))
* set gRPC keep-alive to 120 seconds ([#339](https://www.github.com/googleapis/java-spanner/issues/339)) ([26be103](https://www.github.com/googleapis/java-spanner/commit/26be103da1117c4940550fad1672c66e6edfbdb3))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.3 ([#334](https://www.github.com/googleapis/java-spanner/issues/334)) ([45acd89](https://www.github.com/googleapis/java-spanner/commit/45acd8960c961d48e91a7b1546efa64d9e9ae576))
* update shared config to 0.9.2 ([#328](https://www.github.com/googleapis/java-spanner/issues/328)) ([75df62c](https://www.github.com/googleapis/java-spanner/commit/75df62c0176137fda1d0a9076b83be06f11228ce))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ansh0l pushed a commit to ansh0l/java-spanner that referenced this issue Nov 10, 2022
@yoshi-automation
auto-regenerate .pb.go files (googleapis#327)
08878b7 
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genmgr will
update the corresponding CL at gocloud to depend on the newer version of
go-genproto, and assign reviewers. Whilst this or any regen PR is open in
go-genproto, gapicgen will not create any more regeneration PRs or CLs. If all
regen PRs are closed, gapicgen will create a new set of regeneration PRs and
CLs once per night.

If you have been assigned to review this CL, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
  genmgr to assign reviewers to the gocloud CL.

Corresponding gocloud CL: https://code-review.googlesource.com/c/gocloud/+/53550
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this issue Nov 17, 2022
@renovate-bot
test(deps): update dependency com.google.truth:truth to v1.1.2 (googl…
1dbdaf5 
…eapis#327)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix potential unnecessary transaction retry googleapis/java-spanner
3 participants
@skuruppu @olavloite @yoshi-automation