New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: exposes default leader in database, and leader options / replicas in instance config #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes the list of leader options for an instance from an instance config.
product-auto-label
bot
added
the
api: spanner
Issues related to the googleapis/java-spanner API.
label
Jul 6, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jul 6, 2021
thiagotnunes
added
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
and removed
cla: yes
This human has signed the Contributor License Agreement.
labels
Jul 6, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jul 6, 2021
Backend has not enabled this functionality yet, so the integration tests should not succeed for the moment. |
hengfengli
reviewed
Jul 6, 2021
google-cloud-spanner/src/test/java/com/google/cloud/spanner/DatabaseTest.java
Show resolved
Hide resolved
hengfengli
approved these changes
Jul 6, 2021
I don't the emulator would support |
@hengfengli thanks, will do |
olavloite
reviewed
Jul 6, 2021
google-cloud-spanner/src/main/java/com/google/cloud/spanner/ReplicaInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseInfo.java
Outdated
Show resolved
Hide resolved
Skips leader options / replicas checking related tests for the emulator.
thiagotnunes
added
cla: yes
This human has signed the Contributor License Agreement.
and removed
cla: yes
This human has signed the Contributor License Agreement.
labels
Jul 15, 2021
hengfengli
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
and removed
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
labels
Jul 16, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 16, 2021
hengfengli
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 16, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jul 16, 2021
We decided not to have setting the default leader tests, because it requires a multi-regional instance. The one we currently have for running the tests is regional, so the cost of setup would not justify the testing. We also skip the get leader options test, since the feature is not enabled in production yet.
olavloite
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/java-spanner API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the functionality for CMMR phase 1. Here we do the following:
TODO