test: unflake testCloseResultSetWhileRequestInFlight (#834)

googleapis · Jan 31, 2021 · f218a19 · f218a19
1 parent 41f4aad
commit f218a19
Show file tree

Hide file tree

Showing 3 changed files with 1,451 additions and 1,432 deletions.
diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java
@@ -786,7 +786,7 @@ static class GrpcStreamIterator extends AbstractIterator<PartialResultSet>
     private final Statement statement;
 
     private SpannerRpc.StreamingCall call;
-    private boolean withBeginTransaction;
+    private volatile boolean withBeginTransaction;
     private SpannerException error;
 
     @VisibleForTesting
@@ -889,12 +889,6 @@ public void onError(SpannerException e) {
         error = e;
         addToStream(END_OF_STREAM);
       }
-
-      // Visible only for testing.
-      @VisibleForTesting
-      void setCall(SpannerRpc.StreamingCall call, boolean withBeginTransaction) {
-        GrpcStreamIterator.this.setCall(call, withBeginTransaction);
-      }
     }
   }