Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: re-enable JDBC converter test #348

Merged
merged 1 commit into from Feb 9, 2021
Merged

Conversation

olavloite
Copy link
Collaborator

Re-enables a test that had been disabled because of an issue with pre-epoch Timestamps in java-core.

@olavloite olavloite added the type: cleanup An internal cleanup or hygiene concern. label Feb 8, 2021
@olavloite olavloite requested a review from a team as a code owner February 8, 2021 19:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #348 (c84681b) into master (2f94976) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #348   +/-   ##
=========================================
  Coverage     71.98%   71.98%           
  Complexity     1131     1131           
=========================================
  Files            24       24           
  Lines          3520     3520           
  Branches        537      537           
=========================================
  Hits           2534     2534           
  Misses          767      767           
  Partials        219      219           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f94976...c84681b. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 907760f into master Feb 9, 2021
@thiagotnunes thiagotnunes deleted the reenable-converter-test branch February 9, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants