chore(deps): the libraries BOM 15.0.0 #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
|
Warning: This pull request is touching the following templated files:
|
|
Build failed. https://github.com/googleapis/java-spanner-jdbc/pull/251/checks?check_run_id=1344099221 Looking into this. "ci / dependencies (8)" and On protobuf-lite, there's a pull request for the libraries BOM (https://github.com/GoogleCloudPlatform/cloud-opensource-java/pull/1774/files) to upgrade gRPC version from 1.33.0 to 1.33.1. Where is this On org.apache.httpcomponents:httpclient:4.5.12, ??? It's good to have Dependency TreeTree with the libraries BOM 13.4.0Tree with the masterAs per the effective pom, grpc-protobuf-lite:1.32.1 is coming from io.grpc:grpc-bom:1.32.1. The shared-dependencies-bom 0.10.0 https://search.maven.org/artifact/com.google.cloud/google-cloud-shared-dependencies/0.10.0/pom has |
suztomo
changed the title
|
Warning: This pull request is touching the following templated files:
|
|
Warning: This pull request is touching the following templated files:
|
|
053eb20 fails with NoSuchMethodError in test. The short answer seems that google-cloud-spanner's test library does not work with grpc 1.33.0. But I don't see why the NoSuchMethodError occurs. Interestingly the missing method does not appear in the output of the Linkage Checker enforcer rule: https://gist.github.com/suztomo/08b56722ced2deb805afa3fdfffd5989 JdbcQueryOptionsTest extends AbstractMockServerTest, which calls As per IntelliJ, Google-cloud-spanner:2.0.2 used grpc 1.32.1 to test. The grpc-api 1.33.0's ForwardingServerBuilder's T needs to extend ForwardingServerBuilder in grpc 1.33.0. Although the method Why is it looking for AbstractServerImplBuilder rather than NettyServerBuilder? The javap command shows the method invocation is looking for Where is Google Cloud Spanner 2.0.2 coming from?The Libraries BOM has google-cloud-spanner 2.0.2. (link) The latest google-cloud-spanner 3.0.1 still has grpc 1.32.1 dependency (link) |
This was referenced Nov 3, 2020
|
Warning: This pull request is touching the following templated files:
|
suztomo
changed the title
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
=========================================
Coverage 71.40% 71.40%
Complexity 1104 1104
=========================================
Files 24 24
Lines 3396 3396
Branches 525 525
=========================================
Hits 2425 2425
Misses 756 756
Partials 215 215 Continue to review full report at Codecov.
|
thiagotnunes
approved these changes
Nov 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #235 (which was for libraries-bom 12.0.0)