Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix javadoc formatting #343

Merged
merged 2 commits into from Feb 8, 2021
Merged

docs: fix javadoc formatting #343

merged 2 commits into from Feb 8, 2021

Conversation

olavloite
Copy link
Collaborator

One of the descriptions of the supported connection properties missed an ending </code> block, which caused the entire formatting to be incorrect.

Fixes #342

One of the descriptions of the supported connection properties missed an ending
</code> block, which caused the entire formatting to be incorrect.

Fixes #342
@olavloite olavloite requested a review from a team as a code owner February 3, 2021 11:09
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #343 (25ed0b4) into master (acf76ee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #343   +/-   ##
=========================================
  Coverage     71.35%   71.35%           
  Complexity     1114     1114           
=========================================
  Files            24       24           
  Lines          3474     3474           
  Branches        531      531           
=========================================
  Hits           2479     2479           
  Misses          778      778           
  Partials        217      217           
Impacted Files Coverage Δ Complexity Δ
...java/com/google/cloud/spanner/jdbc/JdbcDriver.java 62.85% <ø> (ø) 15.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acf76ee...ad7e427. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 2ac1964 into master Feb 8, 2021
@thiagotnunes thiagotnunes deleted the fix-docs-formatting branch February 8, 2021 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for connection properties are not formatted correctly.
3 participants