Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support creating shaded jars #333

Merged
merged 1 commit into from Jan 31, 2021
Merged

feat: support creating shaded jars #333

merged 1 commit into from Jan 31, 2021

Conversation

olavloite
Copy link
Collaborator

Some applications that load multiple JDBC drivers may run into dependency conflicts if other JDBC drivers use the same dependencies but different versions. This problem can be mitigated by creating a jar with shaded dependencies. This change adds a Maven profile for creating shaded jars.

Fixes #316

Some applications that load multiple JDBC drivers may run into dependency
conflicts if other JDBC drivers use the same dependencies but different
versions. This problem can be mitigated by creating a jar with shaded
dependencies. This change adds a Maven profile for creating shaded jars.

Fixes #316
@olavloite olavloite requested review from a team as code owners January 26, 2021 10:34
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Jan 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2021
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #333 (d648165) into master (9d65dab) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #333   +/-   ##
=========================================
  Coverage     71.35%   71.35%           
  Complexity     1114     1114           
=========================================
  Files            24       24           
  Lines          3474     3474           
  Branches        531      531           
=========================================
  Hits           2479     2479           
  Misses          778      778           
  Partials        217      217           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d65dab...d648165. Read the comment docs.

@thiagotnunes thiagotnunes merged commit 8b4e50d into master Jan 31, 2021
@thiagotnunes thiagotnunes deleted the support-shading branch January 31, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relocate common / widely used runtime dependencies in shaded jar
2 participants