Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate common / widely used runtime dependencies in shaded jar #316

Closed
jeffersonatsafe opened this issue Jan 7, 2021 · 2 comments · Fixed by #333
Closed

Relocate common / widely used runtime dependencies in shaded jar #316

jeffersonatsafe opened this issue Jan 7, 2021 · 2 comments · Fixed by #333
Assignees
@thiagotnunes
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jeffersonatsafe
Copy link

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.
We're trying to integrate the shaded jar in our project. However, our project is large and is dependent on older versions of some of the commonly used runtime dependencies (eg: protobuf, guava). When we add the shaded driver jar into our classpath, we're running into dependency conflicts.

Describe the solution you'd like
runtime dependencies in the shaded jar would be relocated with a shaded pattern.

Describe alternatives you've considered
We considered updating the dependencies in our project, but it is not feasible at the moment.

Thanks for considering this request!
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Jan 7, 2021
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jan 7, 2021
@olavloite olavloite added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jan 16, 2021
olavloite added a commit that referenced this issue Jan 26, 2021
@olavloite
feat: support creating shaded jars
d648165 
Some applications that load multiple JDBC drivers may run into dependency
conflicts if other JDBC drivers use the same dependencies but different
versions. This problem can be mitigated by creating a jar with shaded
dependencies. This change adds a Maven profile for creating shaded jars.

Fixes #316
@olavloite olavloite mentioned this issue Jan 26, 2021
Merged
@olavloite
Copy link
Collaborator

@jeffersonatsafe Would you mind trying out the profile in #333 and see if that works for you?

@jeffersonatsafe
Copy link
Author

@olavloite the profile in #333 works! thank you so much!

thiagotnunes pushed a commit that referenced this issue Jan 31, 2021
@olavloite
feat: support creating shaded jars (#333)
8b4e50d 
Some applications that load multiple JDBC drivers may run into dependency
conflicts if other JDBC drivers use the same dependencies but different
versions. This problem can be mitigated by creating a jar with shaded
dependencies. This change adds a Maven profile for creating shaded jars.

Fixes #316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thiagotnunes thiagotnunes

Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support creating shaded jars googleapis/java-spanner-jdbc
4 participants
@thiagotnunes @olavloite @jeffersonatsafe @yoshi-automation