Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for tagging to JDBC connection #270

Merged
merged 4 commits into from Jul 14, 2021
Merged

Conversation

olavloite
Copy link
Collaborator

Adds support for tagging to the JDBC driver.

Depends on the changes in googleapis/java-spanner#623.

@olavloite olavloite added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 13, 2020
@olavloite olavloite requested review from a team as code owners November 13, 2020 17:22
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Nov 13, 2020
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite olavloite removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 14, 2021
@olavloite olavloite merged commit a4bd82c into master Jul 14, 2021
@olavloite olavloite deleted the tagging-support branch July 14, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants