Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add simple connection sample to readme #263

Merged
merged 1 commit into from Nov 8, 2020

Conversation

olavloite
Copy link
Collaborator

Adds a simple code example for connecting to Cloud Spanner using JDBC.
Also fixes a wrong link to the online documentation.

Adds a simple code example for connecting to Cloud Spanner using JDBC.
Also fixes a wrong link to the online documentation.
@olavloite olavloite requested review from a team as code owners November 8, 2020 16:47
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Nov 8, 2020
@codecov
Copy link

codecov bot commented Nov 8, 2020

Codecov Report

Merging #263 (f827826) into master (c9906c9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #263   +/-   ##
=========================================
  Coverage     71.40%   71.40%           
  Complexity     1104     1104           
=========================================
  Files            24       24           
  Lines          3396     3396           
  Branches        525      525           
=========================================
  Hits           2425     2425           
  Misses          756      756           
  Partials        215      215           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9906c9...f827826. Read the comment docs.

Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thiagotnunes thiagotnunes merged commit 3a305ba into master Nov 8, 2020
@thiagotnunes thiagotnunes deleted the add-example-to-readme branch November 8, 2020 23:09
@olavloite
Copy link
Collaborator Author

@thiagotnunes Seems like this part of the README is also automatically generated. Do you know where we need to make this change to include it in the generation process?

@thiagotnunes
Copy link
Contributor

In the java-spanner repository we have a .readme-partials.yaml which is included in the README generation (see https://github.com/googleapis/java-spanner/blob/master/.readme-partials.yaml).

I think we could add it in such a file here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants