feat: expose more methods from Connection in JDBC #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavloite
added
the
do not merge
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
More methods from the Connection API should be exposed in the Cloud Spanner JDBC Connection interface to make it easier to execute read-only transactions with specific timestamp bounds. Towards #253
olavloite
force-pushed
the
expose-more-connection-api-in-jdbc
branch
from
ba9c863
to
1fac0dc
Compare
thiagotnunes
approved these changes
Nov 9, 2020
olavloite
removed
the
do not merge
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
============================================
- Coverage 71.40% 70.90% -0.51%
Complexity 1104 1104
============================================
Files 24 24
Lines 3396 3420 +24
Branches 525 525
============================================
Hits 2425 2425
- Misses 756 780 +24
Partials 215 215
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More methods from the Connection API should be exposed in the Cloud Spanner JDBC Connection interface to make it easier to execute read-only transactions with specific timestamp bounds.
This PR relies on this PR in the client library that is needed before this can be merged.
Towards #253