Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

Commit

Permalink
ci: linkage monitor CI job to use build.sh (#276)
Browse files Browse the repository at this point in the history
This PR updates the GitHub Actions configuration for Linkage Monitor. Before this change, the CI configuration has "mvn install" command with 6 options. It turned out that a slight difference in the command line option from "build.sh" fails the build in google-auth-library-java repository (GoogleCloudPlatform/cloud-opensource-java#1941). (@Neenu1995 found the build failure. Thanks!)

Therefore, this change updates the configuration so that Linkage Monitor job just uses "build.sh" to install the artifacts into local Maven repository.

# How did I test?

I tested this change in java-spanner repository with this draft PR: googleapis/java-spanner#868

<img width="889" alt="Screen Shot 2021-02-12 at 16 54 18" src="https://user-images.githubusercontent.com/28604/107826467-f3cd5c80-6d52-11eb-86f1-1a8053326978.png">

It succeeded.

Source-Author: Tomo Suzuki <suztomo@google.com>
Source-Date: Tue Feb 16 15:56:09 2021 -0500
Source-Repo: googleapis/synthtool
Source-Sha: f327d3b657a63ae4a8efd7f011a15eacae36b59c
Source-Link: googleapis/synthtool@f327d3b
  • Loading branch information
yoshi-automation committed Feb 19, 2021
1 parent 989efbd commit 55cf226
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 12 deletions.
13 changes: 3 additions & 10 deletions .github/workflows/ci.yaml
Expand Up @@ -55,17 +55,10 @@ jobs:
java-version: 8
- run: java -version
- name: Install artifacts to local Maven repository
run: |
source .kokoro/common.sh
retry_with_backoff 3 10 \
mvn install -B -V \
-Dmaven.test.skip -DskipTests=true \
-Dclirr.skip=true \
-Denforcer.skip=true \
-Dmaven.javadoc.skip=true \
-Dgcloud.download.skip=true
run: .kokoro/build.sh
shell: bash
- uses: GoogleCloudPlatform/cloud-opensource-java/linkage-monitor@v1-linkagemonitor
- name: Validate any conflicts with regard to com.google.cloud:libraries-bom (latest release)
uses: GoogleCloudPlatform/cloud-opensource-java/linkage-monitor@v1-linkagemonitor
lint:
runs-on: ubuntu-latest
steps:
Expand Down
4 changes: 2 additions & 2 deletions synth.metadata
Expand Up @@ -4,14 +4,14 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/java-shared-dependencies.git",
"sha": "614c42376a1ffaf93882d4c00a17d034d2f1486a"
"sha": "4d5e7f720d847918b307a83c95cea10c244ba595"
}
},
{
"git": {
"name": "synthtool",
"remote": "https://github.com/googleapis/synthtool.git",
"sha": "692715c0f23a7bb3bfbbaa300f7620ddfa8c47e5"
"sha": "f327d3b657a63ae4a8efd7f011a15eacae36b59c"
}
}
],
Expand Down

0 comments on commit 55cf226

Please sign in to comment.