Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update doclet test to use updated sdk-platform-java-config artifact #755

Merged
merged 11 commits into from Feb 15, 2024

Conversation

alicejli
Copy link
Contributor

@alicejli alicejli commented Feb 15, 2024

Update javadoc generation with doclet test to use the updated sdk-platform-java-config artifact.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 15, 2024
@alicejli alicejli changed the title chore: merge doclet test with rest of client-library-checks chore: update doclet test to use updated sdk-platform-java-config artifact Feb 15, 2024
@alicejli alicejli marked this pull request as ready for review February 15, 2024 19:20
@alicejli alicejli requested a review from a team as a code owner February 15, 2024 19:20
@alicejli alicejli added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 15, 2024
@alicejli alicejli removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 15, 2024
Copy link
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment.

.kokoro/client-library-check-doclet.sh Show resolved Hide resolved
.kokoro/client-library-check-doclet.sh Outdated Show resolved Hide resolved
@alicejli alicejli merged commit e1c7ae0 into main Feb 15, 2024
48 checks passed
@alicejli alicejli deleted the updateClientLibraryCheck branch February 15, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants