This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
feat: add v1 client #227
Merged
feat: add v1 client #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Nov 16, 2020
product-auto-label
bot
added
the
api: servicedirectory
Issues related to the googleapis/java-servicedirectory API.
label
Nov 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
===========================================
Coverage 75.90% 75.90%
- Complexity 155 310 +155
===========================================
Files 12 24 +12
Lines 1216 2432 +1216
Branches 11 22 +11
===========================================
+ Hits 923 1846 +923
- Misses 270 540 +270
- Partials 23 46 +23
Continue to review full report at Codecov.
|
kolea2
approved these changes
Nov 16, 2020
stephaniewang526
approved these changes
Nov 16, 2020
kolea2
reviewed
Nov 16, 2020
@@ -3,23 +3,31 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just fyi not sure if you want to merge this or let the generator do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the values in here are going to be ok.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 16, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [0.3.0](https://www.github.com/googleapis/java-servicedirectory/compare/v0.2.8...v0.3.0) (2020-11-16) ### Features * add v1 client ([#227](https://www.github.com/googleapis/java-servicedirectory/issues/227)) ([c06a272](https://www.github.com/googleapis/java-servicedirectory/commit/c06a272c0fa377ddde4965fb45f0121dab6f6367)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api: servicedirectory
Issues related to the googleapis/java-servicedirectory API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.