Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

feat: add v1 client #227

Merged
merged 1 commit into from Nov 16, 2020
Merged

feat: add v1 client #227

merged 1 commit into from Nov 16, 2020

Conversation

chingor13
Copy link
Contributor

No description provided.

@chingor13 chingor13 requested a review from a team as a code owner November 16, 2020 18:34
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2020
@product-auto-label product-auto-label bot added the api: servicedirectory Issues related to the googleapis/java-servicedirectory API. label Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #227 (6f54861) into master (2926c88) will not change coverage.
The diff coverage is 75.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #227     +/-   ##
===========================================
  Coverage     75.90%   75.90%             
- Complexity      155      310    +155     
===========================================
  Files            12       24     +12     
  Lines          1216     2432   +1216     
  Branches         11       22     +11     
===========================================
+ Hits            923     1846    +923     
- Misses          270      540    +270     
- Partials         23       46     +23     
Impacted Files Coverage Δ Complexity Δ
...vicedirectory/v1/stub/RegistrationServiceStub.java 4.54% <4.54%> (ø) 1.00 <1.00> (?)
...rvicedirectory/v1/RegistrationServiceSettings.java 11.11% <11.11%> (ø) 2.00 <2.00> (?)
...oud/servicedirectory/v1/LookupServiceSettings.java 24.13% <24.13%> (ø) 2.00 <2.00> (?)
...tory/v1/stub/GrpcLookupServiceCallableFactory.java 25.00% <25.00%> (ø) 2.00 <2.00> (?)
...cloud/servicedirectory/v1/LookupServiceClient.java 37.50% <37.50%> (ø) 5.00 <5.00> (?)
...1/stub/GrpcRegistrationServiceCallableFactory.java 37.50% <37.50%> (ø) 3.00 <3.00> (?)
...ud/servicedirectory/v1/stub/LookupServiceStub.java 50.00% <50.00%> (ø) 1.00 <1.00> (?)
...servicedirectory/v1/RegistrationServiceClient.java 64.15% <64.15%> (ø) 69.00 <69.00> (?)
...ervicedirectory/v1/stub/GrpcLookupServiceStub.java 80.48% <80.48%> (ø) 7.00 <7.00> (?)
...cedirectory/v1/stub/LookupServiceStubSettings.java 81.91% <81.91%> (ø) 10.00 <10.00> (?)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2926c88...6f54861. Read the comment docs.

@@ -3,23 +3,31 @@
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fyi not sure if you want to merge this or let the generator do it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the values in here are going to be ok.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: servicedirectory Issues related to the googleapis/java-servicedirectory API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
3 participants