This repository has been archived by the owner on Sep 16, 2023. It is now read-only.
docs: remove unused region tags #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: securitycenter
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
=========================================
Coverage 83.63% 83.63%
Complexity 548 548
=========================================
Files 18 18
Lines 4081 4081
Branches 62 62
=========================================
Hits 3413 3413
Misses 598 598
Partials 70 70
Continue to review full report at Codecov.
|
|
This should be a trivial PR as the new correct region tags are now used in docs. Please merge, thank you for helping with this and related PRs! |
lesv
approved these changes
Mar 24, 2021
|
Status here? |
lesv
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
It's failing on windows. I'll merge if you are ok with this / can't merge, we typically review and let you merge. |
Windows |
|
@hannah-tsai PTAL |
|
@lesv - I don't know why the windows failure would have anything to do with the changes made, to be frank :/ I also do not have write access to this repository, so I was hoping someone could merge it once it's safe. Thanks for responding, let me know if there's anything further I can do here. |
|
@Strykrol Np - If you just ask to merge on approval in the comments, I usually do it and would have ping'd earlier. Hopefully @hannah-tsai or someone on her team will take a look on Tuesday - most likely it's something that used to be included is required to be added to the |
lesv
added
automerge
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
|
Oh okay, I can do that moving forward - thank you! We'll check back next week. |
|
@lesv bumping 👍 |
lesv
approved these changes
Jun 3, 2021
|
Thank you!! |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 15, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.6.3](https://www.github.com/googleapis/java-securitycenter/compare/v1.6.2...v1.6.3) (2021-06-15) ### Bug Fixes * Update dependencies.sh to not break on mac ([#541](https://www.github.com/googleapis/java-securitycenter/issues/541)) ([87a8fef](https://www.github.com/googleapis/java-securitycenter/commit/87a8fefdd6145fd223bedcc12df98dfdb206bcf6)) ### Documentation * remove unused region tags ([#407](https://www.github.com/googleapis/java-securitycenter/issues/407)) ([ce983f3](https://www.github.com/googleapis/java-securitycenter/commit/ce983f33d2492e8db6eca1cb1f357f40f6ceeac7)) * update currently supported Finding filter fields ([#537](https://www.github.com/googleapis/java-securitycenter/issues/537)) ([75eb8a6](https://www.github.com/googleapis/java-securitycenter/commit/75eb8a6e4e68a348e06ed42483a6674367bf6edb)) ### Dependencies * update dependency com.google.cloud:google-cloud-pubsub to v1.113.3 ([#535](https://www.github.com/googleapis/java-securitycenter/issues/535)) ([2cc66ba](https://www.github.com/googleapis/java-securitycenter/commit/2cc66ba13197f0ef95cdad6555c3d46086dab2b5)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v1.3.0 ([#530](https://www.github.com/googleapis/java-securitycenter/issues/530)) ([eb3a2f0](https://www.github.com/googleapis/java-securitycenter/commit/eb3a2f09798b63819ed4e244f6f4b93f5fcc3254)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalizes work started in #325. These tags have proliferated on Devsite; old tags are safe to remove.