Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

docs: Wrap samples with future prefix #325

Merged
merged 1 commit into from Dec 14, 2020

Conversation

Strykrol
Copy link
Contributor

Standardizing Security Command Center samples to use 'securitycenter' prefixing.

  • Wrapped existing samples to keep published doclinks unbroken
  • Replace region tags that aren't published.

Once this PR is through, published sample inclusions will be updated to use the new prefix, then I'll come through again and remove the unused block wraps.

@Strykrol Strykrol requested a review from a team December 11, 2020 18:59
@snippet-bot
Copy link

snippet-bot bot commented Dec 11, 2020

Here is the summary of possible violations 😱

There are 10 possible violations for not having product prefix.

Here is the summary of changes.

You added 10 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2020
@product-auto-label product-auto-label bot added api: securitycenter Issues related to the googleapis/java-securitycenter API. samples Issues that are directly related to samples. labels Dec 11, 2020
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #325 (942d0b7) into master (04428f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #325   +/-   ##
=========================================
  Coverage     78.42%   78.42%           
  Complexity      455      455           
=========================================
  Files            18       18           
  Lines          4070     4070           
  Branches         61       61           
=========================================
  Hits           3192     3192           
  Misses          809      809           
  Partials         69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04428f3...942d0b7. Read the comment docs.

@lesv lesv added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Dec 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3239d29 into googleapis:master Dec 14, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 14, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 14, 2020
@Strykrol Strykrol deleted the wrapRegionTags branch December 16, 2020 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: securitycenter Issues related to the googleapis/java-securitycenter API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
3 participants