Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

feat: add client code samples #203

Merged
16 commits merged into from Jun 30, 2021
Merged

feat: add client code samples #203

16 commits merged into from Jun 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 22, 2021 •
edited by ghost

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #202 ☕️

@ghost ghost added cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples. api: privateca Issues related to the Certificate Authority Service API. labels Jun 22, 2021
@ghost ghost self-requested a review as a code owner June 22, 2021 16:45
@product-auto-label product-auto-label bot added the api: security-privateca Issues related to the googleapis/java-security-private-ca API. label Jun 22, 2021
@product-auto-label product-auto-label bot removed the api: privateca Issues related to the Certificate Authority Service API. label Jun 22, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jun 22, 2021 •
edited

Here is the summary of changes.

You are about to add 11 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@ghost ghost changed the title Client code samples feat: add client code samples Jun 22, 2021
@ghost ghost assigned eaball35 Jun 23, 2021
Sita04 and others added 9 commits June 26, 2021 02:14
@Sita04
docs: added comments for more context
01386e4
@Sita04
refactor: modified ca param name to disambiguate
be6f0e9
@Sita04
feat: added samples and tests to create, list and revoke certificates
5652d00
@Sita04
chore: modified dependency to include kms
a07a939
@Sita04
Merge remote-tracking branch 'origin/client-code-samples' into client…
bae9b79 
…-code-samples

# Conflicts:
#	samples/snippets/cloud-client/src/main/java/privateca/CreateCAPool.java
#	samples/snippets/cloud-client/src/main/java/privateca/DeleteCertificateAuthority.java
#	samples/snippets/cloud-client/src/main/java/privateca/DisableCertificateAuthority.java
#	samples/snippets/cloud-client/src/main/java/privateca/EnableCertificateAuthority.java
#	samples/snippets/cloud-client/src/test/java/privateca/SnippetsIT.java
@gcf-owl-bot
🦉 Updates from OwlBot
ac97288 
See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md
@Sita04
refactor: improves readability
0683e85
@Sita04
Merge remote-tracking branch 'origin/client-code-samples' into client…
f67b3d0 
…-code-samples

# Conflicts:
#	samples/snippets/cloud-client/src/main/java/privateca/CreateCertificate.java
@gcf-owl-bot
🦉 Updates from OwlBot
79f36b6 
See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md
eaball35
eaball35 approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@eaball35 eaball35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kolea2 PTAL

kolea2
kolea2 reviewed Jun 28, 2021
View reviewed changes
Copy link

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of comments that apply in more than one file (such as class naming, error handling). PTAL

samples/snippets/cloud-client/src/main/java/privateca/CreateCAPool.java Outdated Show resolved Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/CreateCertificate.java Outdated Show resolved Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/CreateCertificate.java Outdated Show resolved Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/DisableCertificateAuthority.java Show resolved Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/CreateCertificate.java Outdated Show resolved Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/DeleteCertificateAuthority.java Outdated Show resolved Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/DeleteCertificateAuthority.java Outdated Show resolved Hide resolved
Sita04 and others added 3 commits June 28, 2021 23:56
@Sita04
refactor: added error reporting context and modified class names to a…
542f54b 
…lign with API design
@Sita04
Merge remote-tracking branch 'origin/client-code-samples' into client…
09b1427 
…-code-samples

# Conflicts:
#	samples/snippets/cloud-client/src/main/java/privateca/CreateCertificate.java
#	samples/snippets/cloud-client/src/main/java/privateca/CreateCertificateAuthority.java
@gcf-owl-bot
🦉 Updates from OwlBot
1fb9659 
See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md
@ghost ghost marked this pull request as draft June 28, 2021 18:34
@ghost ghost marked this pull request as ready for review June 29, 2021 16:39
@ghost ghost requested a review from kolea2 June 29, 2021 16:41
kolea2
kolea2 approved these changes Jun 30, 2021
View reviewed changes
Copy link

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one outstanding comment

@ghost ghost merged commit 161d88d into master Jun 30, 2021
@ghost ghost deleted the client-code-samples branch June 30, 2021 16:30
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 5, 2021
@release-please
chore: release 1.1.0 (#204)
c6ed03d 
🤖 I have created a release \*beep\* \*boop\*
---
## [1.1.0](https://www.github.com/googleapis/java-security-private-ca/compare/v1.0.0...v1.1.0) (2021-07-01)


### Features

* add client code samples ([#203](https://www.github.com/googleapis/java-security-private-ca/issues/203)) ([161d88d](https://www.github.com/googleapis/java-security-private-ca/commit/161d88df6b8461154b756ee3bb70f253802f52ef))


### Bug Fixes

* Add `shopt -s nullglob` to dependencies script ([#1130](https://www.github.com/googleapis/java-security-private-ca/issues/1130)) ([#201](https://www.github.com/googleapis/java-security-private-ca/issues/201)) ([2513c68](https://www.github.com/googleapis/java-security-private-ca/commit/2513c68c402638730c377bbff5febb74c0568653))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v1.4.0 ([#206](https://www.github.com/googleapis/java-security-private-ca/issues/206)) ([cf79193](https://www.github.com/googleapis/java-security-private-ca/commit/cf791935f20ea7365a9713dd37b8a86bdab01dd6))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kolea2 kolea2

@eaball35 eaball35

Labels
api: security-privateca Issues related to the googleapis/java-security-private-ca API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
3 participants
@kolea2 @eaball35 @Sita04