Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

docs: client sample docs update #219

Merged
merged 9 commits into from Aug 3, 2021
Merged

docs: client sample docs update #219

merged 9 commits into from Aug 3, 2021

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Jul 24, 2021

Adding README. Minor doc fixes.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@Sita04 Sita04 added cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples. labels Jul 24, 2021
@product-auto-label product-auto-label bot added the api: security-privateca Issues related to the googleapis/java-security-private-ca API. label Jul 24, 2021
@sushantsikka
Copy link

Nit: can we please replace the variable caPoolName with pool_ID because that's the convention we use in our docs?

@Sita04 Sita04 changed the title Client sample docs update docs: client sample docs update Jul 27, 2021
@Sita04 Sita04 marked this pull request as ready for review August 3, 2021 17:39
@Sita04 Sita04 requested a review from a team as a code owner August 3, 2021 17:39
@Sita04 Sita04 merged commit 5dd4b80 into master Aug 3, 2021
@Sita04 Sita04 deleted the client-sample-docs-update branch August 3, 2021 18:07
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 10, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [2.0.0](https://www.github.com/googleapis/java-security-private-ca/compare/v1.1.0...v2.0.0) (2021-08-10)


### ⚠ BREAKING CHANGES

* mark some bools as optional, correct response type of DeleteCaPool (#216)
* release gapic-generator-java v2.0.0 (#236)

### Features

* release gapic-generator-java v2.0.0 ([#236](https://www.github.com/googleapis/java-security-private-ca/issues/236)) ([7659402](https://www.github.com/googleapis/java-security-private-ca/commit/76594028500490a7c7bf538cdbd41f0a2fe6c2c0))


### Bug Fixes

* changed the crypto public key provider to Bouncy Castle ([#223](https://www.github.com/googleapis/java-security-private-ca/issues/223)) ([ad386a7](https://www.github.com/googleapis/java-security-private-ca/commit/ad386a7288f34e8048783b270866168cd631df5a))
* mark some bools as optional, correct response type of DeleteCaPool ([#216](https://www.github.com/googleapis/java-security-private-ca/issues/216)) ([5f8af42](https://www.github.com/googleapis/java-security-private-ca/commit/5f8af425dfba0ce0b99cba6d046fe474aee9ef96))


### Documentation

* client sample docs update ([#219](https://www.github.com/googleapis/java-security-private-ca/issues/219)) ([5dd4b80](https://www.github.com/googleapis/java-security-private-ca/commit/5dd4b8028ce1b48c6a8f2a470a406d4881f9036d))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2 ([#237](https://www.github.com/googleapis/java-security-private-ca/issues/237)) ([ee1efcf](https://www.github.com/googleapis/java-security-private-ca/commit/ee1efcf546be13334e9eafe0711794cbe35a6f40))
* update dependency org.bouncycastle:bcpkix-jdk15on to v1.69 ([#234](https://www.github.com/googleapis/java-security-private-ca/issues/234)) ([a6d0213](https://www.github.com/googleapis/java-security-private-ca/commit/a6d02135ee8eb1df5252b3027a45318e96771d44))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: security-privateca Issues related to the googleapis/java-security-private-ca API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
3 participants