googleapis · gcf-merge-on-green · Mar 31, 2020 · Mar 31, 2020 · Mar 31, 2020 · Mar 31, 2020
diff --git a/...etmanager/src/main/java/com/google/cloud/secretmanager/v1/SecretManagerServiceClient.java b/...etmanager/src/main/java/com/google/cloud/secretmanager/v1/SecretManagerServiceClient.java
@@ -320,6 +320,9 @@ public final UnaryCallable<ListSecretsRequest, ListSecretsResponse> listSecretsC
    * @param parent Required. The resource name of the project to associate with the
    *     [Secret][google.cloud.secretmanager.v1.Secret], in the format `projects/&#42;`.
    * @param secretId Required. This must be unique within the project.
+   *     <p>A secret ID is a string with a maximum length of 255 characters and can contain
+   *     uppercase and lowercase letters, numerals, and the hyphen (`-`) and underscore (`_`)
+   *     characters.
    * @param secret Required. A [Secret][google.cloud.secretmanager.v1.Secret] with initial field
    *     values.
    * @throws com.google.api.gax.rpc.ApiException if the remote call fails
@@ -353,6 +356,9 @@ public final Secret createSecret(ProjectName parent, String secretId, Secret sec
    * @param parent Required. The resource name of the project to associate with the
    *     [Secret][google.cloud.secretmanager.v1.Secret], in the format `projects/&#42;`.
    * @param secretId Required. This must be unique within the project.
+   *     <p>A secret ID is a string with a maximum length of 255 characters and can contain
+   *     uppercase and lowercase letters, numerals, and the hyphen (`-`) and underscore (`_`)
+   *     characters.
    * @param secret Required. A [Secret][google.cloud.secretmanager.v1.Secret] with initial field
    *     values.
    * @throws com.google.api.gax.rpc.ApiException if the remote call fails

diff --git a/...ager/src/main/java/com/google/cloud/secretmanager/v1beta1/SecretManagerServiceClient.java b/...ager/src/main/java/com/google/cloud/secretmanager/v1beta1/SecretManagerServiceClient.java
@@ -320,6 +320,9 @@ public final UnaryCallable<ListSecretsRequest, ListSecretsResponse> listSecretsC
    * @param parent Required. The resource name of the project to associate with the
    *     [Secret][google.cloud.secrets.v1beta1.Secret], in the format `projects/&#42;`.
    * @param secretId Required. This must be unique within the project.
+   *     <p>A secret ID is a string with a maximum length of 255 characters and can contain
+   *     uppercase and lowercase letters, numerals, and the hyphen (`-`) and underscore (`_`)
+   *     characters.
    * @param secret A [Secret][google.cloud.secrets.v1beta1.Secret] with initial field values.
    * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */
@@ -352,6 +355,9 @@ public final Secret createSecret(ProjectName parent, String secretId, Secret sec
    * @param parent Required. The resource name of the project to associate with the
    *     [Secret][google.cloud.secrets.v1beta1.Secret], in the format `projects/&#42;`.
    * @param secretId Required. This must be unique within the project.
+   *     <p>A secret ID is a string with a maximum length of 255 characters and can contain
+   *     uppercase and lowercase letters, numerals, and the hyphen (`-`) and underscore (`_`)
+   *     characters.
    * @param secret A [Secret][google.cloud.secrets.v1beta1.Secret] with initial field values.
    * @throws com.google.api.gax.rpc.ApiException if the remote call fails
    */

diff --git a/...secretmanager-v1/src/main/java/com/google/cloud/secretmanager/v1/CreateSecretRequest.java b/...secretmanager-v1/src/main/java/com/google/cloud/secretmanager/v1/CreateSecretRequest.java
@@ -195,6 +195,9 @@ public com.google.protobuf.ByteString getParentBytes() {
    *
    * <pre>
    * Required. This must be unique within the project.
+   * A secret ID is a string with a maximum length of 255 characters and can
+   * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+   * underscore (`_`) characters.
    * </pre>
    *
    * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -217,6 +220,9 @@ public java.lang.String getSecretId() {
    *
    * <pre>
    * Required. This must be unique within the project.
+   * A secret ID is a string with a maximum length of 255 characters and can
+   * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+   * underscore (`_`) characters.
    * </pre>
    *
    * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -776,6 +782,9 @@ public Builder setParentBytes(com.google.protobuf.ByteString value) {
      *
      * <pre>
      * Required. This must be unique within the project.
+     * A secret ID is a string with a maximum length of 255 characters and can
+     * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+     * underscore (`_`) characters.
      * </pre>
      *
      * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -798,6 +807,9 @@ public java.lang.String getSecretId() {
      *
      * <pre>
      * Required. This must be unique within the project.
+     * A secret ID is a string with a maximum length of 255 characters and can
+     * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+     * underscore (`_`) characters.
      * </pre>
      *
      * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -820,6 +832,9 @@ public com.google.protobuf.ByteString getSecretIdBytes() {
      *
      * <pre>
      * Required. This must be unique within the project.
+     * A secret ID is a string with a maximum length of 255 characters and can
+     * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+     * underscore (`_`) characters.
      * </pre>
      *
      * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -841,6 +856,9 @@ public Builder setSecretId(java.lang.String value) {
      *
      * <pre>
      * Required. This must be unique within the project.
+     * A secret ID is a string with a maximum length of 255 characters and can
+     * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+     * underscore (`_`) characters.
      * </pre>
      *
      * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -858,6 +876,9 @@ public Builder clearSecretId() {
      *
      * <pre>
      * Required. This must be unique within the project.
+     * A secret ID is a string with a maximum length of 255 characters and can
+     * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+     * underscore (`_`) characters.
      * </pre>
      *
      * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>

diff --git a/...ager-v1/src/main/java/com/google/cloud/secretmanager/v1/CreateSecretRequestOrBuilder.java b/...ager-v1/src/main/java/com/google/cloud/secretmanager/v1/CreateSecretRequestOrBuilder.java
@@ -59,6 +59,9 @@ public interface CreateSecretRequestOrBuilder
    *
    * <pre>
    * Required. This must be unique within the project.
+   * A secret ID is a string with a maximum length of 255 characters and can
+   * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+   * underscore (`_`) characters.
    * </pre>
    *
    * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -71,6 +74,9 @@ public interface CreateSecretRequestOrBuilder
    *
    * <pre>
    * Required. This must be unique within the project.
+   * A secret ID is a string with a maximum length of 255 characters and can
+   * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+   * underscore (`_`) characters.
    * </pre>
    *
    * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>

diff --git a/...-google-cloud-secretmanager-v1/src/main/proto/google/cloud/secretmanager/v1/service.proto b/...-google-cloud-secretmanager-v1/src/main/proto/google/cloud/secretmanager/v1/service.proto
@@ -253,6 +253,10 @@ message CreateSecretRequest {
   ];
 
   // Required. This must be unique within the project.
+  //
+  // A secret ID is a string with a maximum length of 255 characters and can
+  // contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+  // underscore (`_`) characters.
   string secret_id = 2 [(google.api.field_behavior) = REQUIRED];
 
   // Required. A [Secret][google.cloud.secretmanager.v1.Secret] with initial field values.

diff --git a/...ger-v1beta1/src/main/java/com/google/cloud/secretmanager/v1beta1/CreateSecretRequest.java b/...ger-v1beta1/src/main/java/com/google/cloud/secretmanager/v1beta1/CreateSecretRequest.java
@@ -195,6 +195,9 @@ public com.google.protobuf.ByteString getParentBytes() {
    *
    * <pre>
    * Required. This must be unique within the project.
+   * A secret ID is a string with a maximum length of 255 characters and can
+   * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+   * underscore (`_`) characters.
    * </pre>
    *
    * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -217,6 +220,9 @@ public java.lang.String getSecretId() {
    *
    * <pre>
    * Required. This must be unique within the project.
+   * A secret ID is a string with a maximum length of 255 characters and can
+   * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+   * underscore (`_`) characters.
    * </pre>
    *
    * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -770,6 +776,9 @@ public Builder setParentBytes(com.google.protobuf.ByteString value) {
      *
      * <pre>
      * Required. This must be unique within the project.
+     * A secret ID is a string with a maximum length of 255 characters and can
+     * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+     * underscore (`_`) characters.
      * </pre>
      *
      * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -792,6 +801,9 @@ public java.lang.String getSecretId() {
      *
      * <pre>
      * Required. This must be unique within the project.
+     * A secret ID is a string with a maximum length of 255 characters and can
+     * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+     * underscore (`_`) characters.
      * </pre>
      *
      * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -814,6 +826,9 @@ public com.google.protobuf.ByteString getSecretIdBytes() {
      *
      * <pre>
      * Required. This must be unique within the project.
+     * A secret ID is a string with a maximum length of 255 characters and can
+     * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+     * underscore (`_`) characters.
      * </pre>
      *
      * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -835,6 +850,9 @@ public Builder setSecretId(java.lang.String value) {
      *
      * <pre>
      * Required. This must be unique within the project.
+     * A secret ID is a string with a maximum length of 255 characters and can
+     * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+     * underscore (`_`) characters.
      * </pre>
      *
      * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -852,6 +870,9 @@ public Builder clearSecretId() {
      *
      * <pre>
      * Required. This must be unique within the project.
+     * A secret ID is a string with a maximum length of 255 characters and can
+     * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+     * underscore (`_`) characters.
      * </pre>
      *
      * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>

diff --git a/...a1/src/main/java/com/google/cloud/secretmanager/v1beta1/CreateSecretRequestOrBuilder.java b/...a1/src/main/java/com/google/cloud/secretmanager/v1beta1/CreateSecretRequestOrBuilder.java
@@ -59,6 +59,9 @@ public interface CreateSecretRequestOrBuilder
    *
    * <pre>
    * Required. This must be unique within the project.
+   * A secret ID is a string with a maximum length of 255 characters and can
+   * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+   * underscore (`_`) characters.
    * </pre>
    *
    * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
@@ -71,6 +74,9 @@ public interface CreateSecretRequestOrBuilder
    *
    * <pre>
    * Required. This must be unique within the project.
+   * A secret ID is a string with a maximum length of 255 characters and can
+   * contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+   * underscore (`_`) characters.
    * </pre>
    *
    * <code>string secret_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>

diff --git a/...gle-cloud-secretmanager-v1beta1/src/main/proto/google/cloud/secrets/v1beta1/service.proto b/...gle-cloud-secretmanager-v1beta1/src/main/proto/google/cloud/secrets/v1beta1/service.proto
@@ -253,6 +253,10 @@ message CreateSecretRequest {
   ];
 
   // Required. This must be unique within the project.
+  //
+  // A secret ID is a string with a maximum length of 255 characters and can
+  // contain uppercase and lowercase letters, numerals, and the hyphen (`-`) and
+  // underscore (`_`) characters.
   string secret_id = 2 [(google.api.field_behavior) = REQUIRED];
 
   // A [Secret][google.cloud.secrets.v1beta1.Secret] with initial field values.

diff --git a/synth.metadata b/synth.metadata
@@ -1,13 +1,13 @@
 {
-  "updateTime": "2020-03-26T19:00:04.963551Z",
+  "updateTime": "2020-03-31T22:29:41.492140Z",
   "sources": [
     {
       "git": {
         "name": "googleapis",
         "remote": "https://github.com/googleapis/googleapis.git",
-        "sha": "65816afa71e588252b7119dc723592abe51ea106",
-        "internalRef": "303150338",
-        "log": "65816afa71e588252b7119dc723592abe51ea106\nbazel: update gapic-generator-go to v0.12.5 and gapic-generator hash\n\nChanges to gapic-generator-go include:\n* feat: strip invalid link references in comments\n* chore: updating Go deps in bazel repositories\n\nChanges to gapic-generator include:\n* fix: bazel go build gen check for cloud in proto pkg name\n* Revert \"feat: allow static substitution for group name\"\n\nPiperOrigin-RevId: 303150338\n\nd4aa417ed2bba89c2d216900282bddfdafef6128\nFix incorrect retry config in gapic v2 for kms.\n\nPiperOrigin-RevId: 303010132\n\nfd08334533204fdd1b33f79fcb263dbb5bf13de0\nfix: osconfig/v1 update go_gapic_library target to microgen interface\n\nPiperOrigin-RevId: 303007866\n\ne2c0f2a0e06d86b50aba98f67f9f291587d986b3\nUpdate comments for google/rpc/error_details.proto.\n\nPiperOrigin-RevId: 303002528\n\nf786c7586748e78a286b1620ff3ddbf7b4dcab92\nfeat: Add OsConfigService v1 patch APIs.\n\nPiperOrigin-RevId: 302999346\n\n0341fa3fc2f4073a1b1f260d37b2ce620799f545\nTurn on gapic config v2 for kms.\n\nCommitter: @hzyi-google\nPiperOrigin-RevId: 302980301\n\n32dc6e832039b61ac3fb82c72eb0a27570aebcd6\nredis: v1beta1 enables REDIS_5_0 as an option for redis_version field and adds two new redis configs --stream-node-max-entries --stream-node-max-bytes\n\nPiperOrigin-RevId: 302958009\n\n685f16483cc4d87c35051f21f8f13ef4fdc919b4\nredis: v1 enables REDIS_5_0 as an option for redis_version field and adds two new redis configs --stream-node-max-entries --stream-node-max-bytes\n\nPiperOrigin-RevId: 302957729\n\n733cb282ae5e64673ef86c9a5dff647df803d8b7\nAdd GAPIC cofiguration for v1 client library genetration.\n\nPiperOrigin-RevId: 302928200\n\n1b0fff5f2ec6dc4a9443d9b50e70e9c94c30c45b\ndocs: remove an internal lint declaration\n\nPiperOrigin-RevId: 302928106\n\n2be23f3f3036a6f7ce0844def3d2d3da74e5d415\nfix(google/maps): Add post-processing rules for Google Maps APIs\n\nPiperOrigin-RevId: 302925222\n\n"
+        "sha": "dc65f39f33cb139b3a2244199a3e722a4d94b679",
+        "internalRef": "304035052",
+        "log": "dc65f39f33cb139b3a2244199a3e722a4d94b679\nFor Secret Manager v1 and v1beta1, noted Secret ID character limitations.\n\nPiperOrigin-RevId: 304035052\n\n2ee8c4d06db823c29a127709e66c35e38b6e98ab\nchore(deps): Update gax-java dependency\nThis is to integrate java11 incompatibility fix\n\nPiperOrigin-RevId: 304032057\n\nb5c94cec71ea9b840dc0110a0275323313ecc85a\nchore: add java assembly target for orgpolicy BUILD.bazel\n\nPiperOrigin-RevId: 304021854\n\n690f4d6344197fde775230cec165a9db3b3929c7\nchore: use the latest protoc-java-resource-name-plugin in third_party/googleapis WORKSPACE.\n- trace up only one level when calculating parent types with singleton resource names\n\nPiperOrigin-RevId: 304007414\n\n87144228bd9920b824996355f27891310fad5a32\nEnable gapic v2 for DLP.\n\nCommitter: @hzyi-google\nPiperOrigin-RevId: 303999064\n\n17cfae00f2bb51cb1683f017da7e295a1b0f01a8\nAdd a new AuthorizationType for Data Source Definition.\n\nPiperOrigin-RevId: 303992863\n\n6da3d64919c006ef40cad2026f1e39084253afe2\nfix(google/maps): Change importpath to developers.google.com/maps/go.\n\nPiperOrigin-RevId: 303976942\n\n2983dccde54f0ce31793e1e628379616c468aea0\nbuild(google/maps): only modify root build.gradle with ext plugin\n\nPiperOrigin-RevId: 303975876\n\n00f0a285f2716ce57e98afe500e450b17b556ff8\nfix: Integerate gapic-generator java_gapic rules Java11 fix\n\nPiperOrigin-RevId: 303899179\n\na62857d26bd2ae15aec13a9244989e4104195b63\nfix: add proto_package to the artman config of dataproc v1beta2 to make artman smoketest pass.\n\nPiperOrigin-RevId: 303853989\n\nf260ba248df934fd4ddc22950fb529a59d79e0b5\nchore: use the latest gapic-generator in googleapis WORKSPACE.\n- PHP multi-pattern resource name support.\n- Trace up only one level when calculating parent types with singleton resource names\n\nPiperOrigin-RevId: 303836059\n\n89c7d455fffa5d8a7e73c2f4da43a74605ed72a6\nfeat: Add client library options to OsConfigService v1 patch APIs.\n\nPiperOrigin-RevId: 303831150\n\na45b0a2a8f6f497547ab531a4da978c76441d076\ndataproc: add back non-default retry parameters.\ncommitter: @hzyi-google\n\nPiperOrigin-RevId: 303830177\n\nad895ce95f1f6d2261fbbc3e8897958294e4f017\nenable gapic v2 for containeranalysis.\ncommitter: @hzyi-google\n\nPiperOrigin-RevId: 303821111\n\nbaf83e521834b67397839bcbe2d7864b49e38787\nAdding \"resource_reference\" annotations to services.\n\nPiperOrigin-RevId: 303791704\n\n7be2811ad17013a5ea24cd75dfd9e399dd6e18fe\nfix: Update gapic-generator version to pickup discogapic fixes\n\nPiperOrigin-RevId: 303545940\n\nb655808b3481a92f478ae2f828a6ce8220e40f32\ncloudasset: add org policy and access context manager protos to client libraries.\n\nPiperOrigin-RevId: 303527638\n\nd8c5da9a9471659b51d5862dd2ea7ad3c4bc49ef\nPopulate BAZEL.build files for AccessContextManager.\n\nPiperOrigin-RevId: 303526825\n\ncf9db7161cb9d4dbef06cd8bf5354ec485e51e2d\nPopulate BAZEL.build files for OrgPolicy.\n\nPiperOrigin-RevId: 303526702\n\n558b800ed594acc02555cc560fbb39c0e42bc438\nchore: turn on gapic v2 for Dataproc API.\nfix:\n- add missing method signatures\n- remove resource_reference not on a string field\n- adjust resource name pattern orders\n\nPiperOrigin-RevId: 303431167\n\n8eb444cf5ff63f68d826acbb37b2ac3da58655fb\nAdd logging protos for Recommender v1beta1.\n\nPiperOrigin-RevId: 303426030\n\n48a166ce9f6e2a88b10947341b37336fe9dd3478\nPush of PHP, C# and Ruby namespaces\n\nPiperOrigin-RevId: 303302813\n\n42f77489b300df2e27c84a7b65c4e8f04da20981\nThis is first release of the API protos and Bazel BUILD files for the Analytics Management API V1alpha.\n\nPiperOrigin-RevId: 303241805\n\n8bea81bfa461698981b3d3a488a95633d2f6e9ff\nchore: use latest protoc-java-resource-name-plugin in bazel WORKSPACE.\nnew commits:\n- fix: stop generating `parseList` and `toStringList` if a multi-pattern resource name has subclasses (#79)\n\ncommitter: @hzyi-google\nPiperOrigin-RevId: 303197602\n\nb14af92e565264675d6b12cd2c0ded6c94ddd7f8\nfix talent API incorrect placeholders in two resource name patterns.\ncommitter: @hzyi-google\n\nPiperOrigin-RevId: 303189497\n\n8e22db908ae09e1f7e2802c03b4563fd6b524e0e\nchore(google/maps): Update postprocessing script for Java.\n\n- Update root build.gradle to load local plugin\n- Change com.google.api.grpc group to com.google.maps\n\nPiperOrigin-RevId: 303176850\n\n"
       }
     },
     {