feat!: use RecommendationName, remove deprecated recommendation name …

…helper methods (#79) * [CHANGE ME] Re-generated to pick up changes in the API or client library generator. * allow removal of deprecated methods Co-authored-by: Jeff Ching <chingor@google.com>
googleapis · Jan 27, 2020 · 21a5a90 · 21a5a90
1 parent 17a8bba
commit 21a5a90
Show file tree

Hide file tree

Showing 49 changed files with 1,110 additions and 824 deletions.
diff --git a/google-cloud-recommender/clirr-ignored-differences.xml b/google-cloud-recommender/clirr-ignored-differences.xml
@@ -1,25 +1,50 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
 <differences>
-  <!-- TODO(chingor): Remove after 0.2.0 is released -->
+  <!-- TODO(chingor): Remove after 0.3.0 is released -->
   <difference>
-    <differenceType>7004</differenceType>
+    <differenceType>7002</differenceType>
     <className>com/google/cloud/recommender/v1beta1/RecommenderClient</className>
-    <method>com.google.cloud.recommender.v1beta1.RecommenderClient$ListRecommendationsPagedResponse listRecommendations(java.lang.String)</method>
+    <method>java.lang.String formatRecommendationName(java.lang.String, java.lang.String, java.lang.String, java.lang.String)</method>
   </difference>
   <difference>
-    <differenceType>7004</differenceType>
+    <differenceType>7002</differenceType>
     <className>com/google/cloud/recommender/v1beta1/RecommenderClient</className>
-    <method>com.google.cloud.recommender.v1beta1.Recommendation markRecommendationClaimed(java.lang.String, java.lang.String)</method>
+    <method>java.lang.String formatRecommenderName(java.lang.String, java.lang.String, java.lang.String)</method>
   </difference>
   <difference>
-    <differenceType>7004</differenceType>
+    <differenceType>7002</differenceType>
     <className>com/google/cloud/recommender/v1beta1/RecommenderClient</className>
-    <method>com.google.cloud.recommender.v1beta1.Recommendation markRecommendationFailed(java.lang.String, java.lang.String)</method>
+    <method>java.lang.String parseLocationFromRecommendationName(java.lang.String)</method>
   </difference>
   <difference>
-    <differenceType>7004</differenceType>
+    <differenceType>7002</differenceType>
     <className>com/google/cloud/recommender/v1beta1/RecommenderClient</className>
-    <method>com.google.cloud.recommender.v1beta1.Recommendation markRecommendationSucceeded(java.lang.String, java.lang.String)</method>
+    <method>java.lang.String parseLocationFromRecommenderName(java.lang.String)</method>
+  </difference>
+  <difference>
+    <differenceType>7002</differenceType>
+    <className>com/google/cloud/recommender/v1beta1/RecommenderClient</className>
+    <method>java.lang.String parseProjectFromRecommendationName(java.lang.String)</method>
+  </difference>
+  <difference>
+    <differenceType>7002</differenceType>
+    <className>com/google/cloud/recommender/v1beta1/RecommenderClient</className>
+    <method>java.lang.String parseProjectFromRecommenderName(java.lang.String)</method>
+  </difference>
+  <difference>
+    <differenceType>7002</differenceType>
+    <className>com/google/cloud/recommender/v1beta1/RecommenderClient</className>
+    <method>java.lang.String parseRecommendationFromRecommendationName(java.lang.String)</method>
+  </difference>
+  <difference>
+    <differenceType>7002</differenceType>
+    <className>com/google/cloud/recommender/v1beta1/RecommenderClient</className>
+    <method>java.lang.String parseRecommenderFromRecommendationName(java.lang.String)</method>
+  </difference>
+  <difference>
+    <differenceType>7002</differenceType>
+    <className>com/google/cloud/recommender/v1beta1/RecommenderClient</className>
+    <method>java.lang.String parseRecommenderFromRecommenderName(java.lang.String)</method>
   </difference>
 </differences>
diff --git a/...oud-recommender/src/main/java/com/google/cloud/recommender/v1beta1/RecommenderClient.java b/...oud-recommender/src/main/java/com/google/cloud/recommender/v1beta1/RecommenderClient.java
diff --git a/...d-recommender/src/main/java/com/google/cloud/recommender/v1beta1/RecommenderSettings.java b/...d-recommender/src/main/java/com/google/cloud/recommender/v1beta1/RecommenderSettings.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

diff --git a/...le-cloud-recommender/src/main/java/com/google/cloud/recommender/v1beta1/package-info.java b/...le-cloud-recommender/src/main/java/com/google/cloud/recommender/v1beta1/package-info.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -31,8 +31,8 @@
  * <pre>
  * <code>
  * try (RecommenderClient recommenderClient = RecommenderClient.create()) {
- *   String formattedName = RecommenderClient.formatRecommendationName("[PROJECT]", "[LOCATION]", "[RECOMMENDER]", "[RECOMMENDATION]");
- *   Recommendation response = recommenderClient.getRecommendation(formattedName);
+ *   RecommendationName name = RecommendationName.of("[PROJECT]", "[LOCATION]", "[RECOMMENDER]", "[RECOMMENDATION]");
+ *   Recommendation response = recommenderClient.getRecommendation(name);
  * }
  * </code>
  * </pre>

diff --git a/...c/main/java/com/google/cloud/recommender/v1beta1/stub/GrpcRecommenderCallableFactory.java b/...c/main/java/com/google/cloud/recommender/v1beta1/stub/GrpcRecommenderCallableFactory.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

diff --git a/...ommender/src/main/java/com/google/cloud/recommender/v1beta1/stub/GrpcRecommenderStub.java b/...ommender/src/main/java/com/google/cloud/recommender/v1beta1/stub/GrpcRecommenderStub.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

diff --git a/...-recommender/src/main/java/com/google/cloud/recommender/v1beta1/stub/RecommenderStub.java b/...-recommender/src/main/java/com/google/cloud/recommender/v1beta1/stub/RecommenderStub.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

diff --git a/...nder/src/main/java/com/google/cloud/recommender/v1beta1/stub/RecommenderStubSettings.java b/...nder/src/main/java/com/google/cloud/recommender/v1beta1/stub/RecommenderStubSettings.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

diff --git a/...cloud-recommender/src/test/java/com/google/cloud/recommender/v1beta1/MockRecommender.java b/...cloud-recommender/src/test/java/com/google/cloud/recommender/v1beta1/MockRecommender.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

diff --git a/...d-recommender/src/test/java/com/google/cloud/recommender/v1beta1/MockRecommenderImpl.java b/...d-recommender/src/test/java/com/google/cloud/recommender/v1beta1/MockRecommenderImpl.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Google LLC
+ * Copyright 2020 Google LLC
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.