Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support for client partition reassignment handlers #869

Closed
dpcollins-google opened this issue Sep 9, 2021 · 0 comments · Fixed by #886
Closed

Provide support for client partition reassignment handlers #869

dpcollins-google opened this issue Sep 9, 2021 · 0 comments · Fixed by #886
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dpcollins-google
Copy link
Collaborator

We should support client partition reassignment handlers to allow clients to react to lost assignments.

It would be a nice to have if messages on partitions being assigned away could call nack() without needing to install a custom handler.
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Sep 9, 2021
@meredithslota meredithslota added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Sep 14, 2021
@dpcollins-google dpcollins-google mentioned this issue Sep 15, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 16, 2021
@dpcollins-google
feat: Add ReassignmentHandler which is notified on client reassignment (
5bfef8d 
#886)

This enables clients to respond to a reassignment by cancelling outstanding actions and nacking all messages.

Fixes #869
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 16, 2021
@release-please
chore: release 1.2.0 (#887)
a43275d 
🤖 I have created a release \*beep\* \*boop\*
---
## [1.2.0](https://www.github.com/googleapis/java-pubsublite/compare/v1.1.0...v1.2.0) (2021-09-16)


### Features

* Add ReassignmentHandler which is notified on client reassignment ([#886](https://www.github.com/googleapis/java-pubsublite/issues/886)) ([5bfef8d](https://www.github.com/googleapis/java-pubsublite/commit/5bfef8d1cc0597f31422b8567de24df09f1936b3)), closes [#869](https://www.github.com/googleapis/java-pubsublite/issues/869)
* Batch commit requests ([#883](https://www.github.com/googleapis/java-pubsublite/issues/883)) ([5abd97d](https://www.github.com/googleapis/java-pubsublite/commit/5abd97d20f9e121ff91b5d0a33333585fc5c3790))


### Dependencies

* update dependency com.google.cloud:pubsublite-beam-io to v0.20.0 ([#885](https://www.github.com/googleapis/java-pubsublite/issues/885)) ([66d23e3](https://www.github.com/googleapis/java-pubsublite/commit/66d23e3e2fe7b0926963e231341917f6fd0c311e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add ReassignmentHandler which is notified on client reassignment googleapis/java-pubsublite
2 participants
@meredithslota @dpcollins-google