fix: Ensure notifyFailed is called and all services are stopped when a permanent error happens #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a permanent error happens
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsublite
hannahrogers-google
approved these changes
Sep 8, 2021
4 tasks
| try { | ||
| ApiServiceUtils.stopAsync(services); | ||
| } catch (Throwable t) { | ||
| LOGGER.atFine().withCause(t).log("Exception in underlying service shutdown."); | ||
| } | ||
| handlePermanentError(error); |
There was a problem hiding this comment.
We should also likely handle exception from handlePermanentError(error) that was the line that actually caused issue for us.
There was a problem hiding this comment.
Good point. Fixed.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 8, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.0.5](https://www.github.com/googleapis/java-pubsublite/compare/v1.0.4...v1.0.5) (2021-09-08) ### Bug Fixes * Ensure notifyFailed is called and all services are stopped when a permanent error happens ([#860](https://www.github.com/googleapis/java-pubsublite/issues/860)) ([a046b53](https://www.github.com/googleapis/java-pubsublite/commit/a046b53276d8e6a4ca7b9fac090064e900de181c)) ### Dependencies * update dependency com.google.cloud:google-cloud-pubsub to v1.114.1 ([#843](https://www.github.com/googleapis/java-pubsublite/issues/843)) ([04415ec](https://www.github.com/googleapis/java-pubsublite/commit/04415ecf52a9ea731a45ef780cb6b4f64681d1f4)) * update dependency com.google.cloud:google-cloud-pubsub to v1.114.2 ([#848](https://www.github.com/googleapis/java-pubsublite/issues/848)) ([074488e](https://www.github.com/googleapis/java-pubsublite/commit/074488eba32baa48e0543efb044e8f92c5210b15)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.1.0 ([#842](https://www.github.com/googleapis/java-pubsublite/issues/842)) ([e5e66bc](https://www.github.com/googleapis/java-pubsublite/commit/e5e66bc0a50b01474776a79d4d797df102b3eb47)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.2.0 ([#854](https://www.github.com/googleapis/java-pubsublite/issues/854)) ([4ef86a6](https://www.github.com/googleapis/java-pubsublite/commit/4ef86a66dde47adc98dd3fe9f468e571c2e619d4)) * update dependency com.google.errorprone:error_prone_annotations to v2.9.0 ([#838](https://www.github.com/googleapis/java-pubsublite/issues/838)) ([47e48d6](https://www.github.com/googleapis/java-pubsublite/commit/47e48d6ff017eccba94086c8285ad800dd53406f)) * update dependency com.google.errorprone:error_prone_core to v2.9.0 ([#839](https://www.github.com/googleapis/java-pubsublite/issues/839)) ([ebb1bb1](https://www.github.com/googleapis/java-pubsublite/commit/ebb1bb192170d83beb329e582038cd0c59a22152)) * update dependency org.checkerframework:checker-qual to v3.18.0 ([#855](https://www.github.com/googleapis/java-pubsublite/issues/855)) ([c3c8400](https://www.github.com/googleapis/java-pubsublite/commit/c3c8400fe234534023abef96e5b9b1d523e7dfaa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️