fix(test): deflake SubscriptionPartitionProcessorImplTest #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsublite
manuelmenzella-google
changed the title
The test case expects the processor to fail immediately (with deadline of zero) after failing the underlying subscriber. However, the actual failing is done asynchronously. Waiting for a little bit removes the flakiness.
manuelmenzella-google
force-pushed
the
fix-flakiness
branch
from
f1b5912
to
01b0982
Compare
anguillanneuf
approved these changes
Jul 28, 2021
anguillanneuf
changed the title
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 29, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [0.18.0](https://www.github.com/googleapis/java-pubsublite/compare/v0.17.0...v0.18.0) (2021-07-29) ### Features * split versions.txt to independently release the Beam IO ([#766](https://www.github.com/googleapis/java-pubsublite/issues/766)) ([b6e48dc](https://www.github.com/googleapis/java-pubsublite/commit/b6e48dc7f21ad3f8857d42ca2e3ebc549eea35f6)) * Update CloudPubsubChecks to CloudPubsubTransforms ([#730](https://www.github.com/googleapis/java-pubsublite/issues/730)) ([2e10924](https://www.github.com/googleapis/java-pubsublite/commit/2e109244e43ed4beec50ba9cbc5efadddfb53b5c)) ### Bug Fixes * deflake SubscriptionPartitionProcessorImplTest ([#768](https://www.github.com/googleapis/java-pubsublite/issues/768)) ([c34e430](https://www.github.com/googleapis/java-pubsublite/commit/c34e4303cfb8ce9d0b812ad5c1dd306af32a544e)) * remove DlqProvider which should remain in the beam repo and bump beam version ([#772](https://www.github.com/googleapis/java-pubsublite/issues/772)) ([a540c1d](https://www.github.com/googleapis/java-pubsublite/commit/a540c1dd8eb7e7b2e6afd03550433060635a62fc)) ### Dependencies * define Beam version as a Maven property in pom ([#714](https://www.github.com/googleapis/java-pubsublite/issues/714)) ([69106fe](https://www.github.com/googleapis/java-pubsublite/commit/69106fe309040bc24f2af4c70dfddb602963f365)) * update dependency com.google.apis:google-api-services-bigquery to v2-rev20210617-1.32.1 ([#773](https://www.github.com/googleapis/java-pubsublite/issues/773)) ([e904392](https://www.github.com/googleapis/java-pubsublite/commit/e9043922fbf83220aeff301890fc58b33ae925b4)) * Version bump cloud BOM and remove no longer needed dependency management settings ([#777](https://www.github.com/googleapis/java-pubsublite/issues/777)) ([1cd23cb](https://www.github.com/googleapis/java-pubsublite/commit/1cd23cb3295d521453c1658c25468f4bd82962e2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for 10ms for the PartitionProcessor to fail after failing the underlying subscriber.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #767 ☕️