feat: Blocking pull subscriber is AutoCloseable #748

palmere-google · 2021-07-14T21:55:16Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

palmere-google requested a review from a team as a code owner July 14, 2021 21:55

product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jul 14, 2021

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2021

palmere-google changed the title ~~feat: Blocking pull subscriber~~ feat: Blocking pull subscriber is AutoCloseable Jul 14, 2021

feat: Blocking pull subscribe is AutoCloseable

d47226c

palmere-google force-pushed the palmere-dev branch from 872c752 to d47226c Compare July 15, 2021 17:26

dpcollins-google approved these changes Jul 15, 2021

View reviewed changes

palmere-google merged commit fc52221 into master Jul 15, 2021

palmere-google deleted the palmere-dev branch July 15, 2021 17:46

Provide feedback