New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement interfaces and utilities needed for Pub/Sub Lite Kafka shim #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Oct 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
============================================
- Coverage 71.73% 70.91% -0.82%
- Complexity 771 780 +9
============================================
Files 141 145 +4
Lines 4136 4243 +107
Branches 215 216 +1
============================================
+ Hits 2967 3009 +42
- Misses 1044 1107 +63
- Partials 125 127 +2
Continue to review full report at Codecov.
|
product-auto-label
bot
added
the
api: pubsublite
Issues related to the googleapis/java-pubsublite API.
label
Oct 3, 2020
manuelmenzella-google
approved these changes
Oct 5, 2020
pubsublite-kafka-shim/src/main/java/com/google/cloud/pubsublite/kafka/KafkaExceptionUtils.java
Show resolved
Hide resolved
...e-kafka-shim/src/main/java/com/google/cloud/pubsublite/kafka/SingleSubscriptionConsumer.java
Show resolved
Hide resolved
pubsublite-kafka-shim/src/main/java/com/google/cloud/pubsublite/kafka/KafkaExceptionUtils.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsublite
Issues related to the googleapis/java-pubsublite API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also run mvn fmt:format