fix: Make flogger a runtime dependency by default. (#265)

Fixes #213
googleapis · Sep 28, 2020 · 747bc66 · 747bc66
1 parent ce39696
commit 747bc66
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 31 deletions.
diff --git a/README.md b/README.md
@@ -27,13 +27,6 @@ If you are using Maven, add this to your pom.xml file:
   <artifactId>google-cloud-pubsub</artifactId>
   <version>1.108.1</version>
 </dependency>
-<!-- A logging dependency used by the underlying library  -->
-<dependency>
-  <groupId>com.google.flogger</groupId>
-  <artifactId>flogger-system-backend</artifactId>
-  <version>0.5.1</version>
-  <scope>runtime</scope>
-</dependency>
 
 ```
 

diff --git a/google-cloud-pubsublite/pom.xml b/google-cloud-pubsublite/pom.xml
@@ -113,13 +113,15 @@
       <artifactId>grpc-protobuf</artifactId>
     </dependency>
 
-    <!--test dependencies-->
+    <!-- Add system backend as a default dependency. This can be excluded if a different backend is needed.-->
     <dependency>
       <groupId>com.google.flogger</groupId>
       <artifactId>flogger-system-backend</artifactId>
       <version>0.5.1</version>
-      <scope>test</scope>
+      <scope>runtime</scope>
     </dependency>
+
+    <!--test dependencies-->
     <dependency>
       <groupId>com.google.truth</groupId>
       <artifactId>truth</artifactId>

diff --git a/pubsublite-beam-io/pom.xml b/pubsublite-beam-io/pom.xml
@@ -84,12 +84,6 @@
     </dependency>
 
     <!--test dependencies-->
-    <dependency>
-      <groupId>com.google.flogger</groupId>
-      <artifactId>flogger-system-backend</artifactId>
-      <version>0.5.1</version>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>
@@ -143,7 +137,6 @@
             <ignoredUnusedDeclaredDependencies>
               <ignoredUnusedDeclaredDependency>org.hamcrest:hamcrest</ignoredUnusedDeclaredDependency>
               <ignoredUnusedDeclaredDependency>io.grpc:grpc-testing</ignoredUnusedDeclaredDependency>
-              <ignoredUnusedDeclaredDependency>com.google.flogger:flogger-system-backend</ignoredUnusedDeclaredDependency>
               <ignoredUnusedDeclaredDependency>org.apache.beam:beam-runners-direct-java</ignoredUnusedDeclaredDependency>
               <ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependency>
             </ignoredUnusedDeclaredDependencies>

diff --git a/samples/snapshot/pom.xml b/samples/snapshot/pom.xml
@@ -54,14 +54,6 @@
       <version>1.108.1</version>
     </dependency>
 
-    <!-- A logging dependency used by the underlying library  -->
-    <dependency>
-      <groupId>com.google.flogger</groupId>
-      <artifactId>flogger-system-backend</artifactId>
-      <version>0.5.1</version>
-      <scope>runtime</scope>
-    </dependency>
-
     <dependency>
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>

diff --git a/samples/snippets/pom.xml b/samples/snippets/pom.xml
@@ -53,13 +53,6 @@
       <artifactId>google-cloud-pubsub</artifactId>
       <version>1.108.1</version>
     </dependency>
-    <!-- A logging dependency used by the underlying library  -->
-    <dependency>
-      <groupId>com.google.flogger</groupId>
-      <artifactId>flogger-system-backend</artifactId>
-      <version>0.5.1</version>
-      <scope>runtime</scope>
-    </dependency>
     <!-- [END pubsublite_java_dependencies] -->
     <!-- [END pubsublite_install_without_bom] -->