New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: declare google-auth-library-oauth2-http #879
Conversation
@hannahrogers-google @Neenu1995 I think this will fix the potential missing |
The build is failing.
It's used here java-pubsub/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Line 43 in f4ca4b2
Why? How to reproduce?The following command fails:
|
The Maven analyzer plugin somehow marks the auth library unused even though it's actually used. googleapis#879
@@ -147,6 +150,7 @@ | |||
<ignoredUnusedDeclaredDependencies> | |||
<ignoredUnusedDeclaredDependency>io.opencensus:opencensus-impl</ignoredUnusedDeclaredDependency> | |||
<ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependency> | |||
<ignoredUnusedDeclaredDependency>com.google.auth:google-auth-library-oauth2-http</ignoredUnusedDeclaredDependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we won't need to add an exception when compilation becomes really broken after the new release of the shared dependencies BOM.
<dependency> | ||
<groupId>com.google.auth</groupId> | ||
<artifactId>google-auth-library-oauth2-http</artifactId> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would this fail the "ci / dependencies"?
#882 has been merged. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️