Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: update synth.py to exclude samples.yaml #536

Merged
merged 1 commit into from Feb 25, 2021

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Feb 25, 2021

This is to prevent synth from proposing PRs like #533. The synth-proposed change will cause the samples checkstyle test to miss this file https://github.com/googleapis/java-pubsub/blob/master/samples/checkstyle-suppressions.xml and therefore fail the checkstyle test.

The checkstyle exclusions are for classes generated by Avro tools and protoc. They don't comply to the strict checkstyle rules.

@anguillanneuf anguillanneuf requested review from a team as code owners February 25, 2021 00:21
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels Feb 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2021
@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #536 (598f4cc) into master (6f172ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #536   +/-   ##
=========================================
  Coverage     78.79%   78.79%           
  Complexity      376      376           
=========================================
  Files            27       27           
  Lines          3414     3414           
  Branches        171      171           
=========================================
  Hits           2690     2690           
  Misses          651      651           
  Partials         73       73           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f172ae...d5f1f76. Read the comment docs.

Copy link

@shubha-rajan shubha-rajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anguillanneuf anguillanneuf merged commit aec7b12 into master Feb 25, 2021
@anguillanneuf anguillanneuf deleted the anguillanneuf-patch-1 branch February 25, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants