Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate pubsub synth.py to bazel #124

Merged
merged 1 commit into from Apr 1, 2020

Conversation

vam-google
Copy link
Contributor

This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration.

This PR should be pushed after the an already open PR with the braking changes: #113

This PR migrates only synth.py but does not commit the regenerated files. The generation was tested and it works, the updated files are not commited due to breaking changes not related to bazel migration.

This PR should be pushed after the an already open PR with the braking changes: googleapis#113
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2020
@vam-google
Copy link
Contributor Author

@chingor13 PTAL

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #124 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #124   +/-   ##
=========================================
  Coverage     79.56%   79.56%           
  Complexity      308      308           
=========================================
  Files            21       21           
  Lines          2701     2701           
  Branches        133      133           
=========================================
  Hits           2149     2149           
  Misses          477      477           
  Partials         75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26aec5d...ba05f0b. Read the comment docs.

@chingor13 chingor13 merged commit 8fe6fe6 into googleapis:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants