Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

fix: Mark a couple networkconnectivity API fields as required, to match implemented behavior #174

Merged
merged 2 commits into from Nov 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -403,7 +403,7 @@ public final UnaryCallable<GetHubRequest, Hub> getHubCallable() {
*
* @param parent Required. The parent resource.
* @param hub Required. The initial values for a new hub.
* @param hubId Optional. A unique identifier for the hub.
* @param hubId Required. A unique identifier for the hub.
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final OperationFuture<Hub, OperationMetadata> createHubAsync(
Expand Down Expand Up @@ -434,7 +434,7 @@ public final OperationFuture<Hub, OperationMetadata> createHubAsync(
*
* @param parent Required. The parent resource.
* @param hub Required. The initial values for a new hub.
* @param hubId Optional. A unique identifier for the hub.
* @param hubId Required. A unique identifier for the hub.
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final OperationFuture<Hub, OperationMetadata> createHubAsync(
Expand Down Expand Up @@ -984,7 +984,7 @@ public final UnaryCallable<GetSpokeRequest, Spoke> getSpokeCallable() {
*
* @param parent Required. The parent resource.
* @param spoke Required. The initial values for a new spoke.
* @param spokeId Optional. Unique id for the spoke to create.
* @param spokeId Required. Unique id for the spoke to create.
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final OperationFuture<Spoke, OperationMetadata> createSpokeAsync(
Expand Down Expand Up @@ -1015,7 +1015,7 @@ public final OperationFuture<Spoke, OperationMetadata> createSpokeAsync(
*
* @param parent Required. The parent resource.
* @param spoke Required. The initial values for a new spoke.
* @param spokeId Optional. Unique id for the spoke to create.
* @param spokeId Required. Unique id for the spoke to create.
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final OperationFuture<Spoke, OperationMetadata> createSpokeAsync(
Expand Down
Expand Up @@ -15,7 +15,9 @@
*/

/**
* The interfaces provided are listed below, along with usage samples.
* A client to Network Connectivity API
*
* <p>The interfaces provided are listed below, along with usage samples.
*
* <p>======================= HubServiceClient =======================
*
Expand Down
Expand Up @@ -202,10 +202,10 @@ public com.google.protobuf.ByteString getParentBytes() {
*
*
* <pre>
* Optional. A unique identifier for the hub.
* Required. A unique identifier for the hub.
* </pre>
*
* <code>string hub_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string hub_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return The hubId.
*/
Expand All @@ -225,10 +225,10 @@ public java.lang.String getHubId() {
*
*
* <pre>
* Optional. A unique identifier for the hub.
* Required. A unique identifier for the hub.
* </pre>
*
* <code>string hub_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string hub_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return The bytes for hubId.
*/
Expand Down Expand Up @@ -868,10 +868,10 @@ public Builder setParentBytes(com.google.protobuf.ByteString value) {
*
*
* <pre>
* Optional. A unique identifier for the hub.
* Required. A unique identifier for the hub.
* </pre>
*
* <code>string hub_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string hub_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return The hubId.
*/
Expand All @@ -890,10 +890,10 @@ public java.lang.String getHubId() {
*
*
* <pre>
* Optional. A unique identifier for the hub.
* Required. A unique identifier for the hub.
* </pre>
*
* <code>string hub_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string hub_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return The bytes for hubId.
*/
Expand All @@ -912,10 +912,10 @@ public com.google.protobuf.ByteString getHubIdBytes() {
*
*
* <pre>
* Optional. A unique identifier for the hub.
* Required. A unique identifier for the hub.
* </pre>
*
* <code>string hub_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string hub_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @param value The hubId to set.
* @return This builder for chaining.
Expand All @@ -933,10 +933,10 @@ public Builder setHubId(java.lang.String value) {
*
*
* <pre>
* Optional. A unique identifier for the hub.
* Required. A unique identifier for the hub.
* </pre>
*
* <code>string hub_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string hub_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return This builder for chaining.
*/
Expand All @@ -950,10 +950,10 @@ public Builder clearHubId() {
*
*
* <pre>
* Optional. A unique identifier for the hub.
* Required. A unique identifier for the hub.
* </pre>
*
* <code>string hub_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string hub_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @param value The bytes for hubId to set.
* @return This builder for chaining.
Expand Down
Expand Up @@ -56,10 +56,10 @@ public interface CreateHubRequestOrBuilder
*
*
* <pre>
* Optional. A unique identifier for the hub.
* Required. A unique identifier for the hub.
* </pre>
*
* <code>string hub_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string hub_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return The hubId.
*/
Expand All @@ -68,10 +68,10 @@ public interface CreateHubRequestOrBuilder
*
*
* <pre>
* Optional. A unique identifier for the hub.
* Required. A unique identifier for the hub.
* </pre>
*
* <code>string hub_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string hub_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return The bytes for hubId.
*/
Expand Down
Expand Up @@ -202,10 +202,10 @@ public com.google.protobuf.ByteString getParentBytes() {
*
*
* <pre>
* Optional. Unique id for the spoke to create.
* Required. Unique id for the spoke to create.
* </pre>
*
* <code>string spoke_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string spoke_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return The spokeId.
*/
Expand All @@ -225,10 +225,10 @@ public java.lang.String getSpokeId() {
*
*
* <pre>
* Optional. Unique id for the spoke to create.
* Required. Unique id for the spoke to create.
* </pre>
*
* <code>string spoke_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string spoke_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return The bytes for spokeId.
*/
Expand Down Expand Up @@ -870,10 +870,10 @@ public Builder setParentBytes(com.google.protobuf.ByteString value) {
*
*
* <pre>
* Optional. Unique id for the spoke to create.
* Required. Unique id for the spoke to create.
* </pre>
*
* <code>string spoke_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string spoke_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return The spokeId.
*/
Expand All @@ -892,10 +892,10 @@ public java.lang.String getSpokeId() {
*
*
* <pre>
* Optional. Unique id for the spoke to create.
* Required. Unique id for the spoke to create.
* </pre>
*
* <code>string spoke_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string spoke_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return The bytes for spokeId.
*/
Expand All @@ -914,10 +914,10 @@ public com.google.protobuf.ByteString getSpokeIdBytes() {
*
*
* <pre>
* Optional. Unique id for the spoke to create.
* Required. Unique id for the spoke to create.
* </pre>
*
* <code>string spoke_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string spoke_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @param value The spokeId to set.
* @return This builder for chaining.
Expand All @@ -935,10 +935,10 @@ public Builder setSpokeId(java.lang.String value) {
*
*
* <pre>
* Optional. Unique id for the spoke to create.
* Required. Unique id for the spoke to create.
* </pre>
*
* <code>string spoke_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string spoke_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return This builder for chaining.
*/
Expand All @@ -952,10 +952,10 @@ public Builder clearSpokeId() {
*
*
* <pre>
* Optional. Unique id for the spoke to create.
* Required. Unique id for the spoke to create.
* </pre>
*
* <code>string spoke_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string spoke_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @param value The bytes for spokeId to set.
* @return This builder for chaining.
Expand Down
Expand Up @@ -56,10 +56,10 @@ public interface CreateSpokeRequestOrBuilder
*
*
* <pre>
* Optional. Unique id for the spoke to create.
* Required. Unique id for the spoke to create.
* </pre>
*
* <code>string spoke_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string spoke_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return The spokeId.
*/
Expand All @@ -68,10 +68,10 @@ public interface CreateSpokeRequestOrBuilder
*
*
* <pre>
* Optional. Unique id for the spoke to create.
* Required. Unique id for the spoke to create.
* </pre>
*
* <code>string spoke_id = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
* <code>string spoke_id = 2 [(.google.api.field_behavior) = REQUIRED];</code>
*
* @return The bytes for spokeId.
*/
Expand Down
Expand Up @@ -22,8 +22,8 @@
*
*
* <pre>
* A hub is essentially a collection of spokes. A single hub can contain spokes
* from multiple regions. However, all of a hub's spokes must be associated with
* A hub is a collection of spokes. A single hub can contain spokes from
* multiple regions. However, all of a hub's spokes must be associated with
* resources that reside in the same VPC network.
* </pre>
*
Expand Down Expand Up @@ -944,8 +944,8 @@ protected Builder newBuilderForType(com.google.protobuf.GeneratedMessageV3.Build
*
*
* <pre>
* A hub is essentially a collection of spokes. A single hub can contain spokes
* from multiple regions. However, all of a hub's spokes must be associated with
* A hub is a collection of spokes. A single hub can contain spokes from
* multiple regions. However, all of a hub's spokes must be associated with
* resources that reside in the same VPC network.
* </pre>
*
Expand Down
Expand Up @@ -174,7 +174,7 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ "networkconnectivity.googleapis.com/Hub\"\267"
+ "\001\n\020CreateHubRequest\0229\n\006parent\030\001 \001(\tB)\340A\002"
+ "\372A#\n!locations.googleapis.com/Location\022\023"
+ "\n\006hub_id\030\002 \001(\tB\003\340A\001\022:\n\003hub\030\003 \001(\0132(.googl"
+ "\n\006hub_id\030\002 \001(\tB\003\340A\002\022:\n\003hub\030\003 \001(\0132(.googl"
+ "e.cloud.networkconnectivity.v1.HubB\003\340A\002\022"
+ "\027\n\nrequest_id\030\004 \001(\tB\003\340A\001\"\235\001\n\020UpdateHubRe"
+ "quest\0224\n\013update_mask\030\001 \001(\0132\032.google.prot"
Expand All @@ -195,7 +195,7 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ "leapis.com/Spoke\"\277\001\n\022CreateSpokeRequest\022"
+ "9\n\006parent\030\001 \001(\tB)\340A\002\372A#\n!locations.googl"
+ "eapis.com/Location\022\025\n\010spoke_id\030\002 \001(\tB\003\340A"
+ "\001\022>\n\005spoke\030\003 \001(\0132*.google.cloud.networkc"
+ "\002\022>\n\005spoke\030\003 \001(\0132*.google.cloud.networkc"
+ "onnectivity.v1.SpokeB\003\340A\002\022\027\n\nrequest_id\030"
+ "\004 \001(\tB\003\340A\001\"\243\001\n\022UpdateSpokeRequest\0224\n\013upd"
+ "ate_mask\030\001 \001(\0132\032.google.protobuf.FieldMa"
Expand Down