Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

chore: remove unused dependency #281

Merged
merged 2 commits into from Oct 12, 2020
Merged

chore: remove unused dependency #281

merged 2 commits into from Oct 12, 2020

Conversation

suraj-qlogic
Copy link
Contributor

No description provided.

@suraj-qlogic suraj-qlogic requested a review from a team as a code owner September 29, 2020 06:44
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2020
@product-auto-label product-auto-label bot added the api: monitoring Issues related to the googleapis/java-monitoring API. label Sep 29, 2020
elharo
elharo reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow. This seems to add a dependency, not remo0ve it?

@suraj-qlogic suraj-qlogic added the type: cleanup An internal cleanup or hygiene concern. label Sep 29, 2020
@suraj-qlogic suraj-qlogic self-assigned this Sep 29, 2020
@suraj-qlogic
Copy link
Contributor Author

@elharo, this change removes the dependency on google-auth-library-oauth2-http which is not required anymore after #230 has merged.You probably looked at the second commit, where commons-cli deleted by mistake in the first commit is restored.

@suraj-qlogic
Copy link
Contributor Author

@chingor13 ,gentle ping

@chingor13 chingor13 merged commit a789c8f into googleapis:master Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@elharo elharo elharo approved these changes

Assignees

@suraj-qlogic suraj-qlogic

Labels
api: monitoring Issues related to the googleapis/java-monitoring API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
3 participants
@suraj-qlogic @chingor13 @elharo