Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doc): fix duplicated region tag #622

Merged
merged 1 commit into from Aug 12, 2021

Conversation

minherz
Copy link
Contributor

@minherz minherz commented Aug 12, 2021

Removes duplicated region tag logging_list_log_entries from ListLogs.java

The #602 introduced duplicated region tag logging_list_log_entries in two files: ListLogs.java and ListLogEntries.java. It was done to avoid breaking DevSite build as part of the effort to move list log entries snippet into the new file.

This PR resolves the duplication by removing the tag from ListLogs.java.

remove duplicated region tag logging_list_log_entries from ListLogs.java
@minherz minherz requested a review from a team as a code owner August 12, 2021 18:42
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Aug 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
@snippet-bot
Copy link

snippet-bot bot commented Aug 12, 2021

Here is the summary of possible violations 😱

There is a possible violation for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.


You are about to delete the following sample browser page.

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@minherz minherz marked this pull request as draft August 12, 2021 18:44
@minherz minherz marked this pull request as ready for review August 12, 2021 20:54
@minherz minherz merged commit 1b3ba0b into master Aug 12, 2021
@minherz minherz deleted the minherz/fix-duplicated-region-tag branch August 12, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants