New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cloud function autodetection #533
Conversation
simonz130
commented
May 19, 2021
- Adds Cloud Function auto-detection. Currently relies on environment variables
google-cloud-logging/src/main/java/com/google/cloud/logging/MonitoredResourceUtil.java
Outdated
Show resolved
Hide resolved
ae9809a
to
7c21cb9
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
@@ -216,6 +227,12 @@ private static String getValue(Label label, String resourceType) { | |||
|
|||
/* Detect monitored Resource type using environment variables, else return global as default. */ | |||
private static Resource getAutoDetectedResourceType() { | |||
|
|||
// TODO detect the function from metadata server. If not available - use env var | |||
if (System.getenv("FUNCTION_NAME") != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The public documentation does not describe it but a quick test discovers the following environment variables set (for golang environment): K_REVISION
, GCF_BLOCK_RUNTIME_go112
, GCF_BLOCK_RUNTIME_nodejs6
, K_SERVICE
, FUNCTION_TARGET
, FUNCTION_SIGNATURE_TYPE
. There is no FUNCTION_NAME
environment variable.
Duplicates #708 |