Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make TransportChannel autocloseable #212

Merged
merged 2 commits into from Sep 8, 2020
Merged

fix: make TransportChannel autocloseable #212

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31f6093
fix: make TransportChannel autocloseable
suraj-qlogic Aug 17, 2020
62d94ad
fix: review changes
suraj-qlogic Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 13 additions & 10 deletions google-cloud-logging/src/main/java/com/google/cloud/logging/spi/v2/GrpcLoggingRpc.java
View file
Open in desktop
Expand Up @@ -100,16 +100,19 @@ public GrpcLoggingRpc(final LoggingOptions options) throws IOException {
.usePlaintext()
.executor(executor)
.build();
TransportChannel transportChannel = GrpcTransportChannel.create(managedChannel);
clientContext =
ClientContext.newBuilder()
.setCredentials(null)
.setExecutor(executor)
.setTransportChannel(transportChannel)
.setDefaultCallContext(GrpcCallContext.of(managedChannel, CallOptions.DEFAULT))
.setBackgroundResources(
Collections.<BackgroundResource>singletonList(transportChannel))
.build();
try (TransportChannel transportChannel = GrpcTransportChannel.create(managedChannel)) {
clientContext =
ClientContext.newBuilder()
.setCredentials(null)
.setExecutor(executor)
.setTransportChannel(transportChannel)
.setDefaultCallContext(GrpcCallContext.of(managedChannel, CallOptions.DEFAULT))
.setBackgroundResources(
Collections.<BackgroundResource>singletonList(transportChannel))
.build();
} catch (Exception ex) {
throw new IOException(ex);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the catch block for this try?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

} else {
LoggingSettingsBuilder settingsBuilder =
new LoggingSettingsBuilder(LoggingSettings.newBuilder().build());
Expand Down