fix: fix samples region tags and test flakiness #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: logging
|
Here is the summary of changes. You are about to add 2 region tags.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
google-cla
bot
added
the
cla: yes
simonz130
approved these changes
Sep 22, 2021
define timestamp filter in UTC time. change filter to last minute entries. enforce closing logging client at the end of the snippet. apply formatting.
force closing logging client at the end of the snippet
change logging_write_request_entry to logging_write_log_entry_advanced
add closing logging client at the end of the test unit add multiple attempts to clean log after each test print debug info in a case cleaning fails
remove unused textPayload from the snippet
minherz
force-pushed
the
minherz/fix-region-tags
branch
from
d36ce9e
to
9dca5bb
Compare
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [3.2.0](https://www.github.com/googleapis/java-logging/compare/v3.1.2...v3.2.0) (2021-09-27) ### Features * Add a sample snippet for use of the tailLogEntries API ([8115888](https://www.github.com/googleapis/java-logging/commit/81158885911e6c150fa04053fc41f95640329548)) * add support for tailLogEntry API ([5a7845a](https://www.github.com/googleapis/java-logging/commit/5a7845a8c6476ca2d80e6fffdcb2f5f061f6260b)) ### Bug Fixes * add space to fix embedding exclusion in docs ([#615](https://www.github.com/googleapis/java-logging/issues/615)) ([9d70b96](https://www.github.com/googleapis/java-logging/commit/9d70b96914ae6217cbe58ab1af93e1d5dfe67ce1)) * fix samples region tags and test flakiness ([#680](https://www.github.com/googleapis/java-logging/issues/680)) ([53481bd](https://www.github.com/googleapis/java-logging/commit/53481bde1e455037cd8102bc1b404ea2c491c235)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.3.0 ([#681](https://www.github.com/googleapis/java-logging/issues/681)) ([9be4047](https://www.github.com/googleapis/java-logging/commit/9be4047f5631c824e3f07cfc8c21211168bd51d4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
logging_write_log_entryandlogging_write_log_entry_advancedregion tags to the correct sample snippets.Update samples test for the snippets accordingly.
Resolve
java.lang.RuntimeExceptionexception that appears in the samples tests output.Modify the samples test to eliminate incorrect output in the faked stdout that leads to failed asserts (in testListLogEntriesSample).
Fixes #679