Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add label fullStacktrace #40

Merged
merged 2 commits into from Dec 13, 2019
Merged

feat: add label fullStacktrace #40

merged 2 commits into from Dec 13, 2019

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Dec 5, 2019

Fixes #34

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2019
@codecov
Copy link

codecov bot commented Dec 5, 2019 •
edited

Codecov Report

Merging #40 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #40   +/-   ##
=========================================
  Coverage     76.24%   76.24%           
  Complexity      571      571           
=========================================
  Files            42       42           
  Lines          3334     3334           
  Branches        232      232           
=========================================
  Hits           2542     2542           
  Misses          647      647           
  Partials        145      145

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5c129...41bca75. Read the comment docs.

@athakor athakor mentioned this pull request Dec 5, 2019
Closed
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2019
chingor13
chingor13 approved these changes Dec 12, 2019
View reviewed changes
...loud-logging-logback/src/test/java/com/google/cloud/logging/logback/LoggingAppenderTest.java Outdated
@@ -115,6 +116,7 @@ public void testFilterLogsOnlyLogsAtOrAboveLogLevel() {
.put("levelName", "ERROR")
.put("levelValue", String.valueOf(40000L))
.put("loggerName", this.getClass().getName())
.put("fullStacktrace", "this is a test".trim())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there's an extra space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2019
@athakor athakor merged commit 43e1953 into googleapis:master Dec 13, 2019
@athakor athakor deleted the logging-34 branch December 13, 2019 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@elharo elharo elharo approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stacktrace should not be written to log message
5 participants
@athakor @chingor13 @elharo @googlebot @kokoro-team