Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging : Add Label fullStacktrace #6551

Closed
wants to merge 3 commits into from

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Oct 23, 2019

Fixes #4835

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2019
@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #6551 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6551      +/-   ##
============================================
+ Coverage     46.34%   46.35%   +<.01%     
- Complexity    27997    28013      +16     
============================================
  Files          2613     2613              
  Lines        288068   288069       +1     
  Branches      33778    33773       -5     
============================================
+ Hits         133516   133520       +4     
+ Misses       144312   144309       -3     
  Partials      10240    10240
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/logging/logback/LoggingAppender.java 64.06% <100%> (+0.28%) 28 <0> (ø) ⬇️
.../cloud/datastore/testing/LocalDatastoreHelper.java 85.07% <0%> (+4.47%) 17% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f643b...b83a0fe. Read the comment docs.

@athakor
Copy link
Contributor Author

athakor commented Oct 24, 2019

@chingor13 PTAL

@athakor
Copy link
Contributor Author

athakor commented Dec 5, 2019

Already raised same PR in java-logging repo.

@athakor athakor closed this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants