fix: make TransportChannel autocloseable (#212)

* fix: make TransportChannel autocloseable * fix: review changes
googleapis · Sep 8, 2020 · e4853b1 · e4853b1
1 parent b635585
commit e4853b1
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/google-cloud-logging/src/main/java/com/google/cloud/logging/spi/v2/GrpcLoggingRpc.java b/google-cloud-logging/src/main/java/com/google/cloud/logging/spi/v2/GrpcLoggingRpc.java
@@ -100,16 +100,19 @@ public GrpcLoggingRpc(final LoggingOptions options) throws IOException {
                 .usePlaintext()
                 .executor(executor)
                 .build();
-        TransportChannel transportChannel = GrpcTransportChannel.create(managedChannel);
-        clientContext =
-            ClientContext.newBuilder()
-                .setCredentials(null)
-                .setExecutor(executor)
-                .setTransportChannel(transportChannel)
-                .setDefaultCallContext(GrpcCallContext.of(managedChannel, CallOptions.DEFAULT))
-                .setBackgroundResources(
-                    Collections.<BackgroundResource>singletonList(transportChannel))
-                .build();
+        try (TransportChannel transportChannel = GrpcTransportChannel.create(managedChannel)) {
+          clientContext =
+              ClientContext.newBuilder()
+                  .setCredentials(null)
+                  .setExecutor(executor)
+                  .setTransportChannel(transportChannel)
+                  .setDefaultCallContext(GrpcCallContext.of(managedChannel, CallOptions.DEFAULT))
+                  .setBackgroundResources(
+                      Collections.<BackgroundResource>singletonList(transportChannel))
+                  .build();
+        } catch (Exception ex) {
+          throw new IOException(ex);
+        }
       } else {
         LoggingSettingsBuilder settingsBuilder =
             new LoggingSettingsBuilder(LoggingSettings.newBuilder().build());