Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: add unit testing for MonitoredResourceUtil
refactor MonitoredResourceUtil code to allow mocking getenv() and getAttribute(). unit test each resource type with extra test for GAE FE and custom params.
- Loading branch information
Showing
3 changed files
with
384 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
...e-cloud-logging/src/main/java/com/google/cloud/logging/ResourceTypeEnvironmentGetter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Copyright 2021 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.cloud.logging; | ||
|
||
import com.google.cloud.MetadataConfig; | ||
|
||
public interface ResourceTypeEnvironmentGetter { | ||
|
||
/** | ||
* Gets the value of the specified environment variable. | ||
* | ||
* @param name the name of the environment variable | ||
* @return the string value of the variable, or <code>null</code> if the variable is not defined | ||
* in the system environment | ||
* @see System#getenv() | ||
*/ | ||
String getEnv(String name); | ||
|
||
/** | ||
* Gets the value of the specified metadata server attribute. | ||
* | ||
* @param name the name of the metadata server attribute. | ||
* @return the string value of the attribute, or <code>null</code> if the attribute is not defined | ||
* in the metadata or the server is not available. | ||
* @see MetadataConfig#getAttribute() | ||
*/ | ||
String getAttribute(String name); | ||
} | ||
|
||
final class ResourceTypeEnvironmentGetterImpl implements ResourceTypeEnvironmentGetter { | ||
|
||
@Override | ||
public String getEnv(String name) { | ||
return System.getenv(name); | ||
} | ||
|
||
@Override | ||
public String getAttribute(String name) { | ||
return MetadataConfig.getAttribute(name); | ||
} | ||
} |
Oops, something went wrong.