Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds support to group logs of the same http request #257

Merged
merged 4 commits into from Dec 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -0,0 +1,55 @@
/*
* Copyright 2020 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.google.cloud.logging.logback;

import ch.qos.logback.classic.spi.ILoggingEvent;
import com.google.cloud.logging.LogEntry;
import org.slf4j.MDC;

/** Adds support for grouping logs by incoming http request */
public class TraceLoggingEventEnhancer implements LoggingEventEnhancer {

// A key used by Cloud Logging for trace Id
private static final String TRACE_ID = "logging.googleapis.trace";

/**
* Set the Trace ID associated with any logging done by the current thread.
*
* @param id The traceID, in the form projects/[PROJECT_ID]/traces/[TRACE_ID]
*/
public static void setCurrentTraceId(String id) {
MDC.put(TRACE_ID, id);
}

/**
* Get the Trace ID associated with any logging done by the current thread.
*
* @return id The traceID
*/
public static String getCurrentTraceId() {
return MDC.get(TRACE_ID);
}

@Override
public void enhanceLogEntry(LogEntry.Builder builder, ILoggingEvent e) {
Object value = e.getMDCPropertyMap().get(TRACE_ID);
String traceId = value != null ? value.toString() : null;
if (traceId != null) {
builder.setTrace(traceId);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it suppose to be configured adding a label for stack driver to recognize it

   builder.addLabel("trace_id", traceId);

https://cloud.google.com/logging/docs/setup/java#flexible_environment?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @darewreck54, I realized that my PR description was not accurate - it didn't include instructions to add logging event appender for logback to use:

LoggingAppender cloudAppender = new LoggingAppender();
cloudAppender.addLoggingEventEnhancer("com.google.cloud.logging.logback.TraceLoggingEventEnhancer");

I just tested the code you provided earlier to illustrate what you wanted to achieve with request grouping, with the new feature introduced in this PR and it worked for me on AppEngine Flex.
We will update official documentation to include info about request logs grouping and I updated this PR's description.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonz130 I had another question. Is this library meant to be used service deployed in GKE? I noticed the recommended way is to pipe logs to stdout, but this approach pipes it to a file. https://cloud.google.com/solutions/best-practices-for-operating-containers#use_the_native_logging_mechanisms_of_containers

Any suggestion from that stand front?

}
}
}
@@ -0,0 +1,64 @@
/*
* Copyright 2020 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.google.cloud.logging.logback;

import static com.google.common.truth.Truth.assertThat;

import ch.qos.logback.classic.spi.LoggingEvent;
import com.google.cloud.logging.LogEntry;
import com.google.cloud.logging.Payload.StringPayload;
import org.junit.Before;
import org.junit.Test;

public class TraceLoggingEventEnhancerTest {
private TraceLoggingEventEnhancer classUnderTest;

@Before
public void setUp() {
classUnderTest = new TraceLoggingEventEnhancer();
}

@Test
public void testEnhanceLogEntry() {
// setup
String traceId = "abc";
TraceLoggingEventEnhancer.setCurrentTraceId(traceId);
LoggingEvent loggingEvent = new LoggingEvent();
loggingEvent.setMessage("this is a test");
LogEntry.Builder builder = LogEntry.newBuilder(StringPayload.of("this is a test"));

// act
classUnderTest.enhanceLogEntry(builder, loggingEvent);
LogEntry logEntry = builder.build();

// assert - Trace Id should be recorded as explicit Trace field, not as a label
assertThat(traceId.equalsIgnoreCase(logEntry.getTrace()));
}

@Test
public void testGetCurrentTraceId() {
// setup
String traceId = "abc";
TraceLoggingEventEnhancer.setCurrentTraceId(traceId);

// act
String currentTraceId = TraceLoggingEventEnhancer.getCurrentTraceId();

// assert
assertThat(traceId.equalsIgnoreCase(currentTraceId));
}
}