New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose flush() method #62

Merged

chingor13 merged 1 commit into googleapis:master from suraj-qlogic:logging-logback-58

Apr 1, 2020

Contributor

suraj-qlogic commented Apr 1, 2020

Fixes #58


          feat: expose flush() method in LoggingAppender

954ff5c

googlebot added the cla: yes label

athakor added the kokoro:force-run label

athakor requested a review from codyoss

April 1, 2020 17:36

yoshi-kokoro removed the kokoro:force-run label

codecov bot commented Apr 1, 2020 •

edited

Codecov Report

Merging #62 into master will decrease coverage by 0.10%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master      #62      +/-   ##
============================================
- Coverage     69.17%   69.06%   -0.11%     
- Complexity       34       35       +1     
============================================
  Files             2        2              
  Lines           133      139       +6     
  Branches         14       14              
============================================
+ Hits             92       96       +4     
- Misses           30       31       +1     
- Partials         11       12       +1

Impacted Files	Coverage Δ	Complexity Δ
.../google/cloud/logging/logback/LoggingAppender.java	`68.42% <66.66%> (-0.09%)`	`31.00 <1.00> (+1.00)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13eb882...954ff5c. Read the comment docs.

codyoss requested a review from a team

April 1, 2020 17:57

elharo approved these changes

View reviewed changes

codyoss approved these changes

View reviewed changes

chingor13 merged commit 70375e1 into googleapis:master

gcf-merge-on-green bot pushed a commit that referenced this pull request


          chore: release 0.117.0 (#64)

2df607e

🤖 I have created a release \*beep\* \*boop\* 
---
## [0.117.0](https://www.github.com/googleapis/java-logging-logback/compare/0.116.0...v0.117.0) (2020-04-02)


### Features

* expose flush() method in  LoggingAppender ([#62](https://www.github.com/googleapis/java-logging-logback/issues/62)) ([70375e1](https://www.github.com/googleapis/java-logging-logback/commit/70375e14c9c1e0c76906c87c923e23cd7f6118e8))


### Bug Fixes

* logback error show in error reporting console ([#43](https://www.github.com/googleapis/java-logging-logback/issues/43)) ([1baab89](https://www.github.com/googleapis/java-logging-logback/commit/1baab895770144febcab3384dcfb6e7bfa896787))


### Dependencies

* update core dependencies ([#11](https://www.github.com/googleapis/java-logging-logback/issues/11)) ([8c06e9a](https://www.github.com/googleapis/java-logging-logback/commit/8c06e9ab3fc44bd738e80fc966e739e8cb9f70bb))
* update core dependencies ([#18](https://www.github.com/googleapis/java-logging-logback/issues/18)) ([58f36de](https://www.github.com/googleapis/java-logging-logback/commit/58f36dec1a48f5d2a68b1327251350265941b438))
* update dependency com.google.api:api-common to v1.9.0 ([#56](https://www.github.com/googleapis/java-logging-logback/issues/56)) ([e68627a](https://www.github.com/googleapis/java-logging-logback/commit/e68627aff308f83406cd6f83fcd4c121e9d15e5c))
* update dependency com.google.cloud:google-cloud-core to v1.92.4 ([#32](https://www.github.com/googleapis/java-logging-logback/issues/32)) ([8b9574d](https://www.github.com/googleapis/java-logging-logback/commit/8b9574de2a70a5672cbfa13c3d13684066f8be05))
* update dependency com.google.cloud:google-cloud-core to v1.92.5 ([dd8b483](https://www.github.com/googleapis/java-logging-logback/commit/dd8b48348c5a04f42e963bf1cc5d427aa6e56d3a))
* update dependency com.google.cloud:google-cloud-core to v1.93.1 ([#44](https://www.github.com/googleapis/java-logging-logback/issues/44)) ([ba71ed8](https://www.github.com/googleapis/java-logging-logback/commit/ba71ed8c018b837ffd526228541f87c8ac6207f9))
* update dependency com.google.cloud:google-cloud-core to v1.93.3 ([#45](https://www.github.com/googleapis/java-logging-logback/issues/45)) ([7c30736](https://www.github.com/googleapis/java-logging-logback/commit/7c3073662bc4537c8f6a08325d52d2f1ce3dee22))
* update dependency com.google.cloud:google-cloud-logging to v1.101.0 ([#47](https://www.github.com/googleapis/java-logging-logback/issues/47)) ([585d442](https://www.github.com/googleapis/java-logging-logback/commit/585d44214e8564d8eef6f545110d244148a5f1c9))
* update dependency com.google.cloud.samples:shared-configuration to v1.0.13 ([#55](https://www.github.com/googleapis/java-logging-logback/issues/55)) ([13eb882](https://www.github.com/googleapis/java-logging-logback/commit/13eb882573a0ae91f1875b1f554809d0682e1b64))
* update dependency com.google.guava:guava-bom to v28.2-android ([#15](https://www.github.com/googleapis/java-logging-logback/issues/15)) ([2b7877d](https://www.github.com/googleapis/java-logging-logback/commit/2b7877dc4978043609a47fe0f7dfa8914c9e2622))
* update dependency org.slf4j:slf4j-api to v1.7.30 ([#12](https://www.github.com/googleapis/java-logging-logback/issues/12)) ([ce949a0](https://www.github.com/googleapis/java-logging-logback/commit/ce949a0ee0f10d1276ce3da94230c6e5f57e7b4b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment