Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README.md #174

Merged
merged 1 commit into from Nov 5, 2020

Conversation

dominique-roux
Copy link
Contributor

The log level for warning is WARN, not WARNING
If you use WARNING it is ignored.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

The log level for warning is WARN, not WARNING
If you use WARNING it is ignored.
@dominique-roux dominique-roux requested a review from a team as a code owner September 23, 2020 14:11
@google-cla
Copy link

google-cla bot commented Sep 23, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 23, 2020
@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #174   +/-   ##
=========================================
  Coverage     68.05%   68.05%           
  Complexity       35       35           
=========================================
  Files             2        2           
  Lines           144      144           
  Branches         15       15           
=========================================
  Hits             98       98           
  Misses           33       33           
  Partials         13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f343b10...950eadc. Read the comment docs.

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging-logback API. label Sep 24, 2020
@elharo elharo changed the title Update README.md docs: update README.md Oct 13, 2020
@simonz130 simonz130 self-assigned this Nov 5, 2020
@simonz130 simonz130 added priority: p2 Moderately-important priority. Fix may not be included in next release. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API. automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 5, 2020
@simonz130 simonz130 added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 5, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7c70aa6 into googleapis:master Nov 5, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging-logback API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. priority: p2 Moderately-important priority. Fix may not be included in next release. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants