Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Commit

Permalink
samples: clean up samples pom.xml files (#179)
Browse files Browse the repository at this point in the history
* samples: clean up samples pom.xml files

Skip showing the bom installation method until we add google-cloud-game-services
to libraries-bom

* samples: fix version in install without bom until this version is released
  • Loading branch information
chingor13 committed Jul 22, 2020
1 parent a755d5b commit bf4cc03
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 21 deletions.
12 changes: 6 additions & 6 deletions samples/install-without-bom/pom.xml
Expand Up @@ -2,10 +2,10 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>gameservices-install-without-bom</artifactId>
<artifactId>game-servers-install-without-bom</artifactId>
<packaging>jar</packaging>
<name>Google Cloud Gaming Install Without Bom</name>
<url>https://github.com/googleapis/java-gameservices</url>
<url>https://github.com/googleapis/java-game-servers</url>

<!--
The parent pom defines common style checks and testing strategies for our samples.
Expand All @@ -25,13 +25,13 @@


<dependencies>
<!-- [START gameservices_install_without_bom] -->
<!-- [START game_servers_install_without_bom] -->
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-gameservices</artifactId>
<version>0.19.1</version>
<artifactId>google-cloud-game-servers</artifactId>
<version>0.19.2-SNAPSHOT</version>
</dependency>
<!-- [END gameservices_install_without_bom] -->
<!-- [END game_servers_install_without_bom] -->

<dependency>
<groupId>junit</groupId>
Expand Down
4 changes: 2 additions & 2 deletions samples/pom.xml
Expand Up @@ -2,11 +2,11 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-gameservices-samples</artifactId>
<artifactId>google-cloud-game-servers-samples</artifactId>
<version>0.0.1-SNAPSHOT</version><!-- This artifact should not be released -->
<packaging>pom</packaging>
<name>Google Cloud Gaming Samples Parent</name>
<url>https://github.com/googleapis/java-gameservices</url>
<url>https://github.com/googleapis/java-game-servers</url>
<description>
Java idiomatic client for Google Cloud Platform services.
</description>
Expand Down
12 changes: 6 additions & 6 deletions samples/snapshot/pom.xml
Expand Up @@ -2,10 +2,10 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>gameservices-snapshot</artifactId>
<artifactId>game-servers-snapshot</artifactId>
<packaging>jar</packaging>
<name>Google Cloud Gaming Snapshot Samples</name>
<url>https://github.com/googleapis/java-gameservices</url>
<url>https://github.com/googleapis/java-game-servers</url>

<!--
The parent pom defines common style checks and testing strategies for our samples.
Expand All @@ -23,13 +23,14 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>

<!-- {x-version-update-start::current} -->
<dependencies>
<!-- {x-version-update-start:google-cloud-game-servers:current} -->
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-gameservices</artifactId>
<version>0.19.1</version>
<artifactId>google-cloud-game-servers</artifactId>
<version>0.19.2-SNAPSHOT</version>
</dependency>
<!-- {x-version-update-end} -->

<dependency>
<groupId>junit</groupId>
Expand All @@ -44,7 +45,6 @@
<scope>test</scope>
</dependency>
</dependencies>
<!-- {x-version-update-end} -->

<!-- compile and run all snippet tests -->
<build>
Expand Down
12 changes: 5 additions & 7 deletions samples/snippets/pom.xml
Expand Up @@ -2,10 +2,10 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>gameservices-snippets</artifactId>
<artifactId>game-servers-snippets</artifactId>
<packaging>jar</packaging>
<name>Google Cloud Gaming Snippets</name>
<url>https://github.com/googleapis/java-gameservices</url>
<url>https://github.com/googleapis/java-game-servers</url>

<!--
The parent pom defines common style checks and testing strategies for our samples.
Expand All @@ -23,8 +23,6 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>


<!-- [START gameservices_install_with_bom] -->
<dependencyManagement>
<dependencies>
<dependency>
Expand All @@ -38,12 +36,12 @@
</dependencyManagement>

<dependencies>
<!-- TODO: use libraries-bom when google-cloud-game-servers is included -->
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-gameservices</artifactId>
<artifactId>google-cloud-game-servers</artifactId>
<version>0.19.2-SNAPSHOT</version>
</dependency>
<!-- [END gameservices_install_with_bom] -->

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down

0 comments on commit bf4cc03

Please sign in to comment.