Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

fix: Updating behavior of source_upload_url during Get/List function calls #265

Merged
merged 2 commits into from Aug 10, 2021
Merged

fix: Updating behavior of source_upload_url during Get/List function calls #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88a1bcc
fix: Updating behavior of source_upload_url during Get/List function …
gcf-owl-bot[bot] Aug 5, 2021
3563926
🦉 Updates from OwlBot
gcf-owl-bot[bot] Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
45 changes: 36 additions & 9 deletions ...-google-cloud-functions-v1/src/main/java/com/google/cloud/functions/v1/CloudFunction.java
View file
Open in desktop
Expand Up @@ -1022,7 +1022,10 @@ public com.google.cloud.functions.v1.SourceRepositoryOrBuilder getSourceReposito
*
* <pre>
* The Google Cloud Storage signed URL used for source uploading, generated
* by [google.cloud.functions.v1.GenerateUploadUrl][]
* by calling [google.cloud.functions.v1.GenerateUploadUrl].
* The signature is validated on write methods {Create, Update}
* The signature is stripped from the Function object on read methods {Get,
* List}
* </pre>
*
* <code>string source_upload_url = 16;</code>
Expand All @@ -1037,7 +1040,10 @@ public boolean hasSourceUploadUrl() {
*
* <pre>
* The Google Cloud Storage signed URL used for source uploading, generated
* by [google.cloud.functions.v1.GenerateUploadUrl][]
* by calling [google.cloud.functions.v1.GenerateUploadUrl].
* The signature is validated on write methods {Create, Update}
* The signature is stripped from the Function object on read methods {Get,
* List}
* </pre>
*
* <code>string source_upload_url = 16;</code>
Expand Down Expand Up @@ -1065,7 +1071,10 @@ public java.lang.String getSourceUploadUrl() {
*
* <pre>
* The Google Cloud Storage signed URL used for source uploading, generated
* by [google.cloud.functions.v1.GenerateUploadUrl][]
* by calling [google.cloud.functions.v1.GenerateUploadUrl].
* The signature is validated on write methods {Create, Update}
* The signature is stripped from the Function object on read methods {Get,
* List}
* </pre>
*
* <code>string source_upload_url = 16;</code>
Expand Down Expand Up @@ -3462,7 +3471,10 @@ public com.google.cloud.functions.v1.SourceRepositoryOrBuilder getSourceReposito
*
* <pre>
* The Google Cloud Storage signed URL used for source uploading, generated
* by [google.cloud.functions.v1.GenerateUploadUrl][]
* by calling [google.cloud.functions.v1.GenerateUploadUrl].
* The signature is validated on write methods {Create, Update}
* The signature is stripped from the Function object on read methods {Get,
* List}
* </pre>
*
* <code>string source_upload_url = 16;</code>
Expand All @@ -3478,7 +3490,10 @@ public boolean hasSourceUploadUrl() {
*
* <pre>
* The Google Cloud Storage signed URL used for source uploading, generated
* by [google.cloud.functions.v1.GenerateUploadUrl][]
* by calling [google.cloud.functions.v1.GenerateUploadUrl].
* The signature is validated on write methods {Create, Update}
* The signature is stripped from the Function object on read methods {Get,
* List}
* </pre>
*
* <code>string source_upload_url = 16;</code>
Expand Down Expand Up @@ -3507,7 +3522,10 @@ public java.lang.String getSourceUploadUrl() {
*
* <pre>
* The Google Cloud Storage signed URL used for source uploading, generated
* by [google.cloud.functions.v1.GenerateUploadUrl][]
* by calling [google.cloud.functions.v1.GenerateUploadUrl].
* The signature is validated on write methods {Create, Update}
* The signature is stripped from the Function object on read methods {Get,
* List}
* </pre>
*
* <code>string source_upload_url = 16;</code>
Expand Down Expand Up @@ -3536,7 +3554,10 @@ public com.google.protobuf.ByteString getSourceUploadUrlBytes() {
*
* <pre>
* The Google Cloud Storage signed URL used for source uploading, generated
* by [google.cloud.functions.v1.GenerateUploadUrl][]
* by calling [google.cloud.functions.v1.GenerateUploadUrl].
* The signature is validated on write methods {Create, Update}
* The signature is stripped from the Function object on read methods {Get,
* List}
* </pre>
*
* <code>string source_upload_url = 16;</code>
Expand All @@ -3558,7 +3579,10 @@ public Builder setSourceUploadUrl(java.lang.String value) {
*
* <pre>
* The Google Cloud Storage signed URL used for source uploading, generated
* by [google.cloud.functions.v1.GenerateUploadUrl][]
* by calling [google.cloud.functions.v1.GenerateUploadUrl].
* The signature is validated on write methods {Create, Update}
* The signature is stripped from the Function object on read methods {Get,
* List}
* </pre>
*
* <code>string source_upload_url = 16;</code>
Expand All @@ -3578,7 +3602,10 @@ public Builder clearSourceUploadUrl() {
*
* <pre>
* The Google Cloud Storage signed URL used for source uploading, generated
* by [google.cloud.functions.v1.GenerateUploadUrl][]
* by calling [google.cloud.functions.v1.GenerateUploadUrl].
* The signature is validated on write methods {Create, Update}
* The signature is stripped from the Function object on read methods {Get,
* List}
* </pre>
*
* <code>string source_upload_url = 16;</code>
Expand Down
15 changes: 12 additions & 3 deletions ...loud-functions-v1/src/main/java/com/google/cloud/functions/v1/CloudFunctionOrBuilder.java
View file
Open in desktop
Expand Up @@ -158,7 +158,10 @@ public interface CloudFunctionOrBuilder
*
* <pre>
* The Google Cloud Storage signed URL used for source uploading, generated
* by [google.cloud.functions.v1.GenerateUploadUrl][]
* by calling [google.cloud.functions.v1.GenerateUploadUrl].
* The signature is validated on write methods {Create, Update}
* The signature is stripped from the Function object on read methods {Get,
* List}
* </pre>
*
* <code>string source_upload_url = 16;</code>
Expand All @@ -171,7 +174,10 @@ public interface CloudFunctionOrBuilder
*
* <pre>
* The Google Cloud Storage signed URL used for source uploading, generated
* by [google.cloud.functions.v1.GenerateUploadUrl][]
* by calling [google.cloud.functions.v1.GenerateUploadUrl].
* The signature is validated on write methods {Create, Update}
* The signature is stripped from the Function object on read methods {Get,
* List}
* </pre>
*
* <code>string source_upload_url = 16;</code>
Expand All @@ -184,7 +190,10 @@ public interface CloudFunctionOrBuilder
*
* <pre>
* The Google Cloud Storage signed URL used for source uploading, generated
* by [google.cloud.functions.v1.GenerateUploadUrl][]
* by calling [google.cloud.functions.v1.GenerateUploadUrl].
* The signature is validated on write methods {Create, Update}
* The signature is stripped from the Function object on read methods {Get,
* List}
* </pre>
*
* <code>string source_upload_url = 16;</code>
Expand Down
8 changes: 6 additions & 2 deletions proto-google-cloud-functions-v1/src/main/proto/google/cloud/functions/v1/functions.proto
View file
Open in desktop
@@ -1,4 +1,4 @@
// Copyright 2020 Google LLC
// Copyright 2021 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -243,7 +243,11 @@ message CloudFunction {
SourceRepository source_repository = 4;

// The Google Cloud Storage signed URL used for source uploading, generated
// by [google.cloud.functions.v1.GenerateUploadUrl][]
// by calling [google.cloud.functions.v1.GenerateUploadUrl].
//
// The signature is validated on write methods {Create, Update}
// The signature is stripped from the Function object on read methods {Get,
// List}
string source_upload_url = 16;
}

Expand Down