Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add flush check in BulkWriter.sendBatchLocked() callback #631

Merged
merged 2 commits into from May 14, 2021
Merged

fix: add flush check in BulkWriter.sendBatchLocked() callback #631

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b018574
fix: add flush check in BulkWriter.sendBatchLocked() callback
May 14, 2021
9f1ae9a
review
May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion google-cloud-firestore/src/main/java/com/google/cloud/firestore/BulkWriter.java
View file
Open in desktop
Expand Up @@ -989,7 +989,9 @@ private void sendBatchLocked(final BulkCommitBatch batch, final boolean flush) {
@Override
public void run() {
synchronized (lock) {
scheduleCurrentBatchLocked(flush);
if (flush) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The if-check can happen outside the synchronized block.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

scheduleCurrentBatchLocked(/* flush= */ true);
}
}
}
},
Expand Down