Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't throw NPE in DocumentSnapshot.getDate() when value is missing #513

Merged
merged 2 commits into from Jan 26, 2021
Merged

fix: don't throw NPE in DocumentSnapshot.getDate() when value is missing #513

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
995b018
fix: don't throw NPE in DocumentSnapshot.getDate() when value is missing
schmidt-sebastian Jan 26, 2021
a650223
Simplify
schmidt-sebastian Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentSnapshot.java
View file
Open in desktop
Expand Up @@ -345,7 +345,8 @@ public Long getLong(@Nonnull String field) {
*/
@Nullable
public Date getDate(@Nonnull String field) {
return ((Timestamp) get(field)).toDate();
Timestamp timestamp = (Timestamp) get(field);
return timestamp == null ? null : timestamp.toDate();
}

/**
Expand Down