New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Release bundles #466
Changes from 3 commits
3d190ec
a28d9eb
f115b40
f42625b
fe05c46
06eae54
d0588f8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,6 +168,24 @@ void getAll( | |
@Nonnull | ||
WriteBatch batch(); | ||
|
||
/** | ||
* Returns a FirestoreBundle.Builder {@link FirestoreBundle.Builder} instance using an | ||
* automatically generated ID. The ID is used by the client SDKs loading bundles to identify if a | ||
* bundle has been loaded before. | ||
*/ | ||
@Nonnull | ||
FirestoreBundle.Builder bundleBuilder(); | ||
|
||
/** | ||
* Returns a FirestoreBundle.Builder {@link FirestoreBundle.Builder} instance for the given bundle | ||
* ID. | ||
* | ||
* @param bundleId The ID is used by the client SDKs loading bundles to identify if a bundle has | ||
* been loaded before. If null, an random string will be used for the ID. | ||
*/ | ||
@Nonnull | ||
FirestoreBundle.Builder bundleBuilder(@Nullable String bundleId); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/ |
||
|
||
/** | ||
* Closes the gRPC channels associated with this instance and frees up their resources. This | ||
* method blocks until all channels are closed. Once this method is called, this Firestore client | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,10 +54,17 @@ public static final class Builder { | |
// The latest read time among all bundled documents and queries. | ||
private Timestamp latestReadTime = Timestamp.MIN_VALUE; | ||
|
||
public Builder(String id) { | ||
Builder(String id) { | ||
this.id = id; | ||
} | ||
|
||
/** | ||
* Returns the ID for this bundle. | ||
*/ | ||
wu-hui marked this conversation as resolved.
Show resolved
Hide resolved
|
||
public String getId() { | ||
return this.id; | ||
} | ||
|
||
/** | ||
* Adds a Firestore document snapshot to the bundle. Both the documents data and the document | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove plural "Both the document data and...." There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
* read time will be included in the bundle. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Line 124-129 below, for add() doc, remove plural so "Adds a Firestore query snapshot to..." There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/an/a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.